-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
invalid (valid) channel name in rust-toolchain #1745
Comments
Hi @mikhail-krainik, Thanks for reporting this. For the edification of others, we had a brief discussion on the rust developers discord in the Cargo channel about all this, becuase Mikhail was trying to force the use of a specific toolchain (including specific architecture) by means of writing a cargo plugin to do this. I asked why he didn't use It's not clear yet whether the right answer is to improve the error message to suggest removing the architecture from the toolchain channel name (or some other improvement to the error message) or to deal with it in some silent, or warning-like, way. @Nemo157 rightly stated that to silently accept the arch iff it's equal to the host arch might be a bit too dangerous since it'd mask an issue for others potentially. Right now, we're not certain what the right approach will be, so further discussion is required. |
@Qquanwei Thank you for confirming that this problem exists for others. Could you provide any insight into why the Also, do you have an opinion on the options mentioned in #1745 (comment) and/or any further ideas to improve the UX here? |
This error is not a common error , when I re-install remacs environment it not appear for me. the only thing that I do is |
@Qquanwei Something else must be putting that file down then - I suggest that if it happens again you grep around looking for what created the file. In the meantime, I'm glad the problem has gone away for you for now. |
I'm getting the same errors when using |
Interesting, you're quite right it does behave badly like that. Hmm... |
I'm running into this as well. The toolchain I built is hooked into rustup using I can do Setting the toolchain to the default using rustup also allows |
Using |
And |
I agree that these later examples are not good, so I'm going to try and resolve this. Whether I end up with something the OP is happy with or not, I'm not sure I can predict; but I'll see what I can do. |
The `rust-toolchain` override file was limited to valid toolchain names. This commit weakens that slightly to permit *any* string so long as it's a local toolchain name. If it's not then it has to be a valid channelish toolchain name instead. This fixes rust-lang#1745 Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
A little more context on this issue, I am trying to deploy a Rust Application to Heroku, and am using Rocket for my REST API. This needs nightly, so I am trying to specify to use the nightly version instead of stable and am getting this error. (because I need to specify it in the rust-toolchain file. |
Problem
I'm trying to get the rust version I need through specifying the version in rust-toolchain
Steps
nightly-2018-11-27-x86_64-unknown-linux-gnu
without any space in the wordPossible Solution(s)
Notes
Output of
rustup --version
:Output of
rustup show
:$ rustup --version
rustup 1.17.0 (069c88e 2019-03-05)
$ rustup show
Default host: x86_64-unknown-linux-gnu
installed toolchains
stable-x86_64-unknown-linux-gnu (default)
beta-x86_64-unknown-linux-gnu
nightly-2018-11-27-x86_64-unknown-linux-gnu
nightly-x86_64-unknown-linux-gnu
active toolchain
(error: invalid channel name 'nightly-2018-11-27-x86_64-unknown-linux-gnu' in '/path/to/project/rust-toolchain')
The text was updated successfully, but these errors were encountered: