Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hints on how to get gcc installed #741

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

highb
Copy link
Contributor

@highb highb commented May 1, 2021

Just tried installing Rustlings using the install.sh script on a fresh Ubuntu install and I forgot to install build-essential so it failed once cargo started trying to compile. This commit adds a check to the script for cc as well as a note to README.md.

I'm not on an OSX system right now, but iirc cc is what the Xcode CLI tools uses, as well so it should work across both platforms. Not sure about Windows.

If you would prefer that I make a PR with only the README.md change, I'm happy to do that.

@shadows-withal shadows-withal merged commit bc56861 into rust-lang:main Feb 4, 2022
@shadows-withal
Copy link
Member

@all-contributors please add @highb for doc

@allcontributors
Copy link
Contributor

@diannasoreil

I've put up a pull request to add @highb! 🎉

@highb highb deleted the highb-install-sh-cc-hint branch February 6, 2022 21:05
dlip added a commit to dlip/rustlings that referenced this pull request Feb 10, 2022
* upstream/main:
  docs: update .all-contributorsrc [skip ci]
  docs: update README.md [skip ci]
  doc: Add hints on how to get gcc installed (rust-lang#741)
  docs: update .all-contributorsrc [skip ci]
  docs: update README.md [skip ci]
  fix(structs3): Add a hint for panic (rust-lang#608)
  fix(errors1): Add a comment to make the purpose more clear (rust-lang#486)
  fix(clippy1): Set clippy::float_cmp lint to deny (rust-lang#907)
  fix(intro1): Add compiler error explanation.
  feat(intro): Add intro section.
  docs(option): improve further information
ppp3 pushed a commit to ppp3/rustlings that referenced this pull request May 23, 2022
dmoore04 pushed a commit to dmoore04/rustlings that referenced this pull request Sep 11, 2022
Spacebody pushed a commit to Spacebody/my-rustlings that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants