Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustlings watch Should clear the shell. #146

Closed
Bykow opened this issue Apr 26, 2019 · 0 comments · Fixed by #227 or #228
Closed

rustlings watch Should clear the shell. #146

Bykow opened this issue Apr 26, 2019 · 0 comments · Fixed by #227 or #228
Labels
A-source Area: CLI source C-feature-request Category: Feature Request P-medium Priority: Medium

Comments

@Bykow
Copy link

Bykow commented Apr 26, 2019

Hey,

First, thank you for this amazing project, learnt a lot at a really high pace with those exercises.

However I used the rustlings watch functionality during my training, and I feel like it could use a clear in the shell to make it easier to see the new results.

I often found myself lost in scrolling between old output and new ones.

Again, thanks for your amazing job !
@komaeda komaeda added A-source Area: CLI source C-feature-request Category: Feature Request labels Apr 27, 2019
@komaeda komaeda added the P-medium Priority: Medium label Jun 12, 2019
@workingjubilee workingjubilee mentioned this issue Nov 9, 2019
Merged
@bors bors closed this as completed in fea8141 Nov 9, 2019
@bors bors closed this as completed in #227 Nov 9, 2019
WofWca added a commit to WofWca/rustlings that referenced this issue Nov 9, 2019
@WofWca
improvement(watch): clear screen before each verify()
3aff590 
Closes rust-lang#146
@WofWca WofWca mentioned this issue Nov 9, 2019
Merged
bors added a commit that referenced this issue Nov 9, 2019
@bors
Auto merge of #228 - WofWca:clear-screen, r=fmoko
3232a4d 
improvement(watch): clear screen before each `verify()`

Closes #146
It seems to me that #227 wasn't really fixing the issue.
ppp3 pushed a commit to ppp3/rustlings that referenced this issue May 23, 2022
Auto merge of rust-lang#227 - workingjubilee:watch-clears-terminal, r…
6d17b8b 
…=fmoko

watch: clears terminal before entering loop

Fixes rust-lang#146

If someone is sliding in and out of "watch" mode, it can make it hard
to tell which error messages are still relevant. This patch resolves
that by clearing the terminal entirely before entering watch's loop.

Note that the escape character is chosen for compatibility reasons, because different shells/terminals can change which commands they accept or have installed, betting on what other commands are in use to collect data seems risky, and just expecting them to implement ANSI escape code sequences is more reliable. This seems especially true since Windows is seeking more UNIX compatibility in its terminals going forward, even though it doesn't implement the POSIX standard per se.
ppp3 pushed a commit to ppp3/rustlings that referenced this issue May 23, 2022
improvement(watch): clear screen before each verify()
34be3ab 
Closes rust-lang#146
ppp3 pushed a commit to ppp3/rustlings that referenced this issue May 23, 2022
Auto merge of rust-lang#228 - WofWca:clear-screen, r=fmoko
287d3c0 
improvement(watch): clear screen before each `verify()`

Closes rust-lang#146
It seems to me that rust-lang#227 wasn't really fixing the issue.
dmoore04 pushed a commit to dmoore04/rustlings that referenced this issue Sep 11, 2022
@bors
Auto merge of rust-lang#227 - workingjubilee:watch-clears-terminal, r…
65e5f6e 
…=fmoko

watch: clears terminal before entering loop

Fixes rust-lang#146

If someone is sliding in and out of "watch" mode, it can make it hard
to tell which error messages are still relevant. This patch resolves
that by clearing the terminal entirely before entering watch's loop.

Note that the escape character is chosen for compatibility reasons, because different shells/terminals can change which commands they accept or have installed, betting on what other commands are in use to collect data seems risky, and just expecting them to implement ANSI escape code sequences is more reliable. This seems especially true since Windows is seeking more UNIX compatibility in its terminals going forward, even though it doesn't implement the POSIX standard per se.
dmoore04 pushed a commit to dmoore04/rustlings that referenced this issue Sep 11, 2022
@WofWca
improvement(watch): clear screen before each verify()
5205415 
Closes rust-lang#146
dmoore04 pushed a commit to dmoore04/rustlings that referenced this issue Sep 11, 2022
@bors
Auto merge of rust-lang#228 - WofWca:clear-screen, r=fmoko
7fb9b17 
improvement(watch): clear screen before each `verify()`

Closes rust-lang#146
It seems to me that rust-lang#227 wasn't really fixing the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-source Area: CLI source C-feature-request Category: Feature Request P-medium Priority: Medium
Projects
None yet
Milestone
No milestone
2 participants
@Bykow @komaeda