Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Updated default version to Rustfmt docs config #4644

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

gunadhya
Copy link
Contributor

@gunadhya gunadhya commented Jan 15, 2021

Fixes (mostly) #4633
Changes:
Updates the default version to the latest version released.

Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful thank you! ❤️

@calebcartwright calebcartwright merged commit 19b34fe into rust-lang:master Jan 21, 2021
@calebcartwright
Copy link
Member

FYI I tweaked the PR description to prevent closing the issue just yet. This change addresses the main issue so I wanted to go ahead and get it out ASAP, but there's a few other edge cases I'd like to tweak as well, for example ensuring the page default is something other than master even if any of the API calls fail:

const versionNumber = null !== versionParam ? parseVersionParam(versionParam) : 'master';

Let me know if you'd be interested in working on that, or really anything else, as there's some other improvements I'd like to see in the config docs as well

@jdahlstrom
Copy link

The doc page does not appear to honor the version GET parameter (anymore?) For example, browse to https://rust-lang.github.io/rustfmt/?version=master&search=#array_width and observe that after a brief flash of correct content, the selected version resets to 1.4.32, the array_width and other non-1.* sections are hidden, and the browser scroll position becomes incorrect.

@gunadhya
Copy link
Contributor Author

The doc page does not appear to honor the version GET parameter (anymore?) For example, browse to https://rust-lang.github.io/rustfmt/?version=master&search=#array_width and observe that after a brief flash of correct content, the selected version resets to 1.4.32, the array_width and other non-1.* sections are hidden, and the browser scroll position becomes incorrect.

@jdahlstrom My bad. I'll try to figure out the cause and find a better way.

@calebcartwright
Copy link
Member

Thanks for the report @jdahlstrom!

@karyon
Copy link
Contributor

karyon commented Oct 26, 2021

backported in #4958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants