-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for nested tuple access #4570
Add test for nested tuple access #4570
Conversation
Thank you for the PR @sasurau4 adding the tests! Be sure to review the additional comments (like #4470 (comment)) on the linked issue that call out a minor code change we want to make as well |
32ac238
to
d086db7
Compare
@calebcartwright Thanks for pointing out. I fixed! |
Perfect thank you. Changes LGTM, though would you mind doing me a favor and including the below snippets in the tests too? They'll be formatted fine here but since these uses cases were reported in #4543 I'd like to include them in the test suite to prevent any future regressions let oid = oid!(1.2.840.113549.1.1.5);
let oid2 = oid!(2.5.4.3); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@calebcartwright Thanks for your review. I added the test for issue-4543 👍 |
Thanks! |
Helps with #4470
cargo make test