Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document RUSTFMT environment variable #4464

Merged
merged 5 commits into from
Oct 11, 2020
Merged

Document RUSTFMT environment variable #4464

merged 5 commits into from
Oct 11, 2020

Conversation

MonliH
Copy link
Contributor

@MonliH MonliH commented Oct 10, 2020

This PR the RUSTFMT environment variable in the readme of this repo, added in #4419.

Closes #4426 once the PR to the cargo book gets accepted.

@calebcartwright
Copy link
Member

Thanks @MonliH! Could you move the text up under the running cargo fmt section? https://github.com/rust-lang/rustfmt#running-cargo-fmt. That'll be the most applicable and logical place to document this feature

@MonliH
Copy link
Contributor Author

MonliH commented Oct 11, 2020

Moved it 👍

calebcartwright
calebcartwright reviewed Oct 11, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
MonliH and others added 3 commits October 11, 2020 15:14
calebcartwright
calebcartwright approved these changes Oct 11, 2020
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@calebcartwright calebcartwright merged commit f352f38 into rust-lang:master Oct 11, 2020
karyon pushed a commit to karyon/rustfmt that referenced this pull request Oct 28, 2021
@MonliH @karyon
Document RUSTFMT environment variable (rust-lang#4464)
72658f8 
* Document RUSTFMT env var

* Move documentation up

* Apply suggestions from code review

Co-authored-by: Caleb Cartwright <calebcartwright@users.noreply.github.com>

* Fix accedental removal

Co-authored-by: Caleb Cartwright <calebcartwright@users.noreply.github.com>
# Conflicts:
#	README.md
@karyon karyon mentioned this pull request Oct 28, 2021
Merged
@karyon karyon added 1x-backport:pending Fixed/resolved in source but not yet backported to a 1x branch and release and removed backport-triage labels Oct 28, 2021
calebcartwright pushed a commit that referenced this pull request Oct 30, 2021
@MonliH @calebcartwright
Document RUSTFMT environment variable (#4464)
a4d7011 
* Document RUSTFMT env var

* Move documentation up

* Apply suggestions from code review

Co-authored-by: Caleb Cartwright <calebcartwright@users.noreply.github.com>

* Fix accedental removal

Co-authored-by: Caleb Cartwright <calebcartwright@users.noreply.github.com>
# Conflicts:
#	README.md
@ytmimi
Copy link
Contributor

ytmimi commented Mar 30, 2022

Backport completed by #5048

@ytmimi ytmimi added 1x-backport:completed and removed 1x-backport:pending Fixed/resolved in source but not yet backported to a 1x branch and release labels Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
1x-backport:completed hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation about RUSTFMT environment variable
4 participants
@MonliH @calebcartwright @ytmimi @karyon