Coalesce some of the import options #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topecongiro
reviewed
Apr 10, 2018
There was a problem hiding this comment.
Thank you for the PR! And my apologies for the late review. The code looks good other than the minor refactoring. Also, I think that we should move the visual guides and unit tests of removed config options to reorder_imports section, rather than removing them entirely.
src/reorder.rs
Outdated
| ReorderableItemKind::ExternCrate => config.reorder_extern_crates_in_group(), | ||
| ReorderableItemKind::Mod => config.reorder_modules(), | ||
| ReorderableItemKind::Use => config.reorder_imports_in_group(), | ||
| ReorderableItemKind::ExternCrate => true, |
There was a problem hiding this comment.
These patterns can be combined into a single pattern.
Configurations.md
Outdated
|
|
||
| ## `reorder_imports` | ||
|
|
||
| Reorder import statements alphabetically | ||
| Reorder import and extern crate statements alphabetically |
There was a problem hiding this comment.
Maybe mention that statements are reordered "in group"? Also, if possible, we should move the examples of removed options under reorder_imports section, rather than removing them entirely.
mati865
added a commit
to mati865/rustfmt
that referenced
this pull request
Apr 17, 2018
Default value changed in rust-lang#2605
topecongiro
pushed a commit
that referenced
this pull request
Apr 17, 2018
Default value changed in #2605
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #2185
r? @topecongiro