Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soft wrapping doc comments #2130

Merged
merged 5 commits into from
Nov 9, 2017
Merged

Soft wrapping doc comments #2130

merged 5 commits into from
Nov 9, 2017

Conversation

topecongiro
Copy link
Contributor

Closes #535.

nrc
nrc reviewed Nov 8, 2017
View reviewed changes
src/visitor.rs Outdated
context: &RewriteContext,
attrs: &'a [ast::Attribute],
pred: P,
) -> Option<&'a [ast::Attribute]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could make the code simple by returning an empty array rather than None.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Updated the PR.

@nrc nrc merged commit 560f66c into rust-lang:master Nov 9, 2017
@nrc
Copy link
Member

nrc commented Nov 9, 2017

Thank you!

@topecongiro topecongiro deleted the soft-wrapping-doc-comments branch May 23, 2018 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrc nrc nrc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@topecongiro @nrc