Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build failure #5859

Closed
matthiaskrgr opened this issue Jul 25, 2023 · 3 comments · Fixed by #5872
Closed

build failure #5859

matthiaskrgr opened this issue Jul 25, 2023 · 3 comments · Fixed by #5872

Comments

@matthiaskrgr
Copy link
Member

cargo check --features generic-simd

error: expected one of `!` or `::`, found keyword `mod`
   --> /home/matthias/.cargo/registry/src/index.crates.io-6f17d22bba15001f/packed_simd_2-0.3.7/src/lib.rs:347:7
    |
347 | crate mod llvm {
    |       ^^^ expected one of `!` or `::`

error: could not compile `packed_simd_2` (lib) due to previous error
@calebcartwright
Copy link
Member

Could you add a little more context please? It's unclear how this relates to rustfmt from the initial issue description

@matthiaskrgr
Copy link
Member Author

matthiaskrgr commented Jul 25, 2023 •
edited
Loading

sorry, rustfmt has a feature "generic-simd" that fails the rustfmt build when it is enabled.

This was found because we run clippy on rustfmt in our CI with --all-targets --all-features.

repro:

git clone https://github.com/rust-lang/rustfmt/
cd rustfmt
cargo check   --features generic-simd

@matthiaskrgr matthiaskrgr mentioned this issue Jul 25, 2023
Merged
bors added a commit to rust-lang/rust-clippy that referenced this issue Jul 26, 2023
@bors
Auto merge of #11225 - matthiaskrgr:fix_integration_tests2, r=flip1995
fc13bf8 
Fix integration tests #2

fix integration tests.

It turned out that the following tests fail to build at all:

chalk, combine, stdarch and hyper.

This is often a problem of passing `--all-targets --all-features`, in case of combine though, outdated deps were to blame.

I have opened tickets against combine and rustfmt
rust-lang/rustfmt#5859
Marwes/combine#357

should we just remove the other failing repos? :/

changelog: fix integration tests on ci
@ytmimi
Copy link
Contributor

ytmimi commented Aug 2, 2023

Confirming I'm able to reproduce this. I'm also pretty sure it's related to llogiq/bytecount#64. I think Bumping the version of bytecount would solve the problem 🤞🏼

@ytmimi ytmimi mentioned this issue Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable rustfmt to compile when using the generic-simd feature ytmimi/rustfmt
3 participants
@matthiaskrgr @calebcartwright @ytmimi