Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline attributes on enum variant fields are handled poorly #1261

Closed
Ms2ger opened this issue Jan 3, 2017 · 1 comment · Fixed by #1634
Closed

Multiline attributes on enum variant fields are handled poorly #1261

Ms2ger opened this issue Jan 3, 2017 · 1 comment · Fixed by #1634

Comments

@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 3, 2017

 pub enum CoreResourceMsg {
     /// Store a cookie for a given originating URL
-    SetCookieForUrl(
-        ServoUrl,
-        #[serde(deserialize_with = "::hyper_serde::deserialize",
+    SetCookieForUrl(ServoUrl,
+                    #[serde(deserialize_with = "::hyper_serde::deserialize",
                 serialize_with = "::hyper_serde::serialize")]
-        Cookie,
-        CookieSource
-    ),
+                    Cookie,
+                    CookieSource),
 }

I would prefer for deserialize_with and serialize_with to remain aligned.

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jan 3, 2017

servo/servo#8553

topecongiro added a commit to topecongiro/rustfmt that referenced this issue Jun 5, 2017
@nrc nrc closed this as completed in #1634 Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants