Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ar git dependency #1155

Closed
bjorn3 opened this issue Mar 31, 2021 · 6 comments · Fixed by rust-lang/rust#97485
Closed

Remove the ar git dependency #1155

bjorn3 opened this issue Mar 31, 2021 · 6 comments · Fixed by rust-lang/rust#97485
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.
Milestone
Distribute as rus...

Comments

@bjorn3
Copy link
Member

bjorn3 commented Mar 31, 2021

https://github.com/bjorn3/rustc_codegen_cranelift/blob/ab425a4bca1d6df234596a1621c4cabcc73bb272/Cargo.toml#L21

It will break the build if for whatever reason this commit/repo is gone in the future. I could make it a git subtree, but I don't know if git subtree supports nesting.
@bjorn3 bjorn3 added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Mar 31, 2021
@bjorn3 bjorn3 added this to the Distribute as rustup component milestone Dec 29, 2021
@bjorn3 bjorn3 mentioned this issue Dec 29, 2021
Closed
@bjorn3
Copy link
Member Author

bjorn3 commented Dec 29, 2021

Quoting from https://github.com/bjorn3/rustc_codegen_cranelift/issues/1202:

https://github.com/bjorn3/rustc_codegen_cranelift/pull/1201 changed the Cranelift deps to crates.io releases.

There is still a git dependency on my fork of the ar crate (https://github.com/bjorn3/rust-ar/tree/do_not_remove_cg_clif_ranlib). I think I will need to fix symbol table support for macOS and then poke the maintainer of rust-ar to release a new version of my PR.

@bjorn3
Copy link
Member Author

bjorn3 commented Feb 20, 2022

I have decided to rewrite llvm's archive builder in rust. This should ensure that the produced archives are correct on all platforms supported by LLVM. The resulting crate will be published on crates.io.

https://github.com/llvm/llvm-project/blob/8ef3e895ad8ab1724e2b87cabad1dacdc7a397a3/llvm/lib/Object/ArchiveWriter.cpp

@bjorn3 bjorn3 mentioned this issue Mar 25, 2022
Closed
@bjorn3 bjorn3 mentioned this issue Jul 31, 2022
Merged
@bjorn3
Copy link
Member Author

bjorn3 commented Aug 13, 2022

rust-lang/rust#97485 will fix this.

bors referenced this issue in rust-lang-ci/rust Dec 3, 2022
@bors
Auto merge of rust-lang#97485 - bjorn3:new_archive_writer, r=wesleywiser
cab4fd6 
Rewrite LLVM's archive writer in Rust

This allows it to be used by other codegen backends.

Fixes https://github.com/bjorn3/rustc_codegen_cranelift/issues/1155
@bjorn3 bjorn3 closed this as completed in f1dc349 Dec 4, 2022
@bjorn3
Copy link
Member Author

bjorn3 commented Dec 4, 2022

Fixed by rust-lang/rust#97485 which is pulled in as of 63fab51.

@bjorn3
Copy link
Member Author

bjorn3 commented Dec 4, 2022

Had to revert the rustc update because of rust-lang/rust#105082. Reopening

@bjorn3 bjorn3 reopened this Dec 4, 2022
RalfJung referenced this issue in RalfJung/miri Dec 5, 2022
@bors
Auto merge of #97485 - bjorn3:new_archive_writer, r=wesleywiser
cd65b1f 
Rewrite LLVM's archive writer in Rust

This allows it to be used by other codegen backends.

Fixes https://github.com/bjorn3/rustc_codegen_cranelift/issues/1155
@bjorn3
Copy link
Member Author

bjorn3 commented Dec 11, 2022

The issue blocking the rustup is now fixed.

@bjorn3 bjorn3 closed this as completed Dec 11, 2022
@jyn514 jyn514 mentioned this issue Apr 8, 2023
Closed
antoyo referenced this issue in rust-lang/rustc_codegen_gcc Jun 3, 2023
@bors
Auto merge of #97485 - bjorn3:new_archive_writer, r=wesleywiser
12224e8 
Rewrite LLVM's archive writer in Rust

This allows it to be used by other codegen backends.

Fixes https://github.com/bjorn3/rustc_codegen_cranelift/issues/1155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
Distribute as rustup component
Development

Successfully merging a pull request may close this issue.

Rewrite LLVM's archive writer in Rust bjorn3/rust
1 participant
@bjorn3