Change style-servo to avoid spurious rebuilds #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old code generation generated different code on rebuilds due to depending on HashSet iteration order; this patch patches that problem by replacing the HashSet with a BTreeSet. --pretty=expanded output is now identical across builds.
|
Looks good to me. Would you please also send a PR upstream for the same change, with a code comment explaining that iteration order affects rebuilds? |
|
Hm, my understanding is that upstream had a larger rewrite that made this unnecessary? Or at least so you indicate in this comment; I don't see any similar looking code in the master version of cg.rs. |
|
Oh that’s right, never mind then :) |
|
Thanks, @Mark-Simulacrum! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old code generation generated different code on rebuilds due to
depending on HashSet iteration order; this patch patches that problem by
replacing the HashSet with a BTreeSet. --pretty=expanded output is now
identical across builds.
cc rust-lang/rust#48184, @SimonSapin @michaelwoerister
I'm not actually sure this fixes the entire problem, but it's probably a good start.