Improve compare cmd UI #1963
Merged
Improve compare cmd UI #1963
+205
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
reviewed
Aug 14, 2024
There was a problem hiding this comment.
Pretty nice, thanks! I think that we should definitely default into instructions. However, with inquire, it's probably quite non-trivial to "go back" and display the metric selector once you have already shown the result. That's something that leads into a more interactive dialog and ratatui. So for now we can keep the metric dialog.
s7tya
force-pushed
the
improve-compare-cmd-ui
branch
2 times, most recently
from
48f404e
to
dcf0405
Compare
|
Thank you for the review! I've fixed them. |
Kobzol
reviewed
Aug 14, 2024
s7tya
force-pushed
the
improve-compare-cmd-ui
branch
from
dcf0405
to
9325e6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the ability to select artifacts and metrics interactively. Now, an interactive prompt will start if the artifacts or metric isn't explicitly specified. I'm curious to know how many people are using a non-instructions:u metric. If the number is significant, we could consider defaulting to instructions:u and disabling the prompt to streamline the user experience.