-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More Clippy lint groups including pedantic #51
base: master
Are you sure you want to change the base?
Conversation
There were also warnings for math formulae and names like SipHash. No change at this time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cast_lossless
and cargo_common_metadata
fixes are a nice touch. everything else however doesn't look like an improvement to me.
Co-authored-by: Joe ST <joe@fbstj.net>
I could remove the nursery group if maintainers prefer, as it is an experimental group.
|
I've just kept the pedantic and cargo lint groups now. This is in line with rust-lang/cargo-bisect-rustc and rust-lang/rustc-perf. |
I did not change my opinions since #51 (review) |
Five lints corrected:
doc_markdown
frompedantic
(partial, see commit message)cast_lossless
frompedantic
use_self
fromnursery
too_long_first_doc_paragraph
fromstyle
cargo_common_metadata
fromcargo
Pedantic, nursery, and cargo group rules are added.
All lints are passing.