Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misguided suggestions in config.toml #840

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Aug 31, 2020

r? @eddyb

@jyn514 jyn514 added the waiting-on-review This PR is waiting for a reviewer to verify its content label Aug 31, 2020
@jyn514
Copy link
Member Author

jyn514 commented Aug 31, 2020

error: Server returned 404 Not Found for https://github.com/rust-lang/rust/tree/master/src/librustc_metadata

    ┌─ query.md:155:1

    │

155 │ [`rustc_metadata` crate][rustc_metadata], which loads the information

    │ ^ Server returned 404 Not Found for https://github.com/rust-lang/rust/tree/master/src/librustc_metadata

Looks like this needs the changes from #838 before CI will pass.

- `verbose-tests` is for debugging the test harness, not the tests
themselves. See also rust-lang/rust#76141
- `codegen-units` defaults to `256` whenever `incremental = true`. So
there's no need to explicitly set it to `0` if we already recommend
incremental. See also rust-lang#795 (comment).
@tshepang tshepang merged commit 9ab5011 into rust-lang:master Aug 31, 2020
@jyn514 jyn514 deleted the config-toml-redux branch August 31, 2020 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-review This PR is waiting for a reviewer to verify its content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants