Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document serialization in rustc #785

Merged
merged 2 commits into from
Aug 16, 2020
Merged

Document serialization in rustc #785

merged 2 commits into from
Aug 16, 2020

Conversation

matthewjasper
Copy link
Contributor

@matthewjasper matthewjasper commented Jul 4, 2020 •
edited
Loading

This documents serialization after rust-lang/rust#73851

@JohnTitor JohnTitor added the S-blocked Status: this PR is blocked waiting for something label Jul 4, 2020
@matthewjasper matthewjasper mentioned this pull request Jul 4, 2020
Closed
3 tasks
mark-i-m
mark-i-m previously requested changes Jul 4, 2020
View reviewed changes
Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @matthewjasper! This is great.

r=me with nits below

src/serialization.md Show resolved Hide resolved
src/serialization.md Outdated Show resolved Hide resolved
src/serialization.md Outdated Show resolved Hide resolved
src/serialization.md Outdated Show resolved Hide resolved
MajorBreakfast
MajorBreakfast reviewed Jul 5, 2020
View reviewed changes
src/serialization.md Outdated Show resolved Hide resolved
@matthewjasper matthewjasper added S-waiting-on-author Status: this PR is waiting for additional action by the OP and removed S-blocked Status: this PR is blocked waiting for something labels Aug 15, 2020
@matthewjasper
Copy link
Contributor Author

@mark-i-m This is now ready to be merged

@JohnTitor JohnTitor removed the S-waiting-on-author Status: this PR is waiting for additional action by the OP label Aug 16, 2020
@mark-i-m mark-i-m merged commit f08527c into rust-lang:master Aug 16, 2020
@matthewjasper matthewjasper deleted the serialization branch August 17, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MajorBreakfast MajorBreakfast MajorBreakfast left review comments

@mark-i-m mark-i-m mark-i-m left review comments

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthewjasper @MajorBreakfast @mark-i-m @JohnTitor