Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect a set of PRs that help understanding some parts of the compiler #619

Open
spastorino opened this issue Mar 17, 2020 · 6 comments
Open

Comments

@spastorino
Copy link
Member

spastorino commented Mar 17, 2020

@rust-lang/wg-learning let's collect here PRs that may help readers understanding different parts of the compiler.

I've started this list, it's raw and there may be things that shouldn't be there but I guessed it would be better to share as is, rather than waiting longer. We can start polishing it, adding more PRs, removing some of them, adding more information next to each PR like explaining what part of the compiler each PR is going to help explaining, etc.

@mark-i-m
Copy link
Member

mark-i-m commented Apr 2, 2020

https://github.com/rust-lang/rust/pull/70645/files

This thread illustrates two things:

  • How to add a lint
  • How to open a PR on April 1

@spastorino
Copy link
Member Author

@mark-i-m when I saw it I thought to add it to the list, please go ahead and add it to the HackMD.

@mark-i-m
Copy link
Member

mark-i-m commented Apr 3, 2020

@spastorino One thing that would be helpful is if (when you have time) you could add for each link what you think is to be learned from that PR.

@bjorn3
Copy link
Member

bjorn3 commented Apr 6, 2020

rust-lang/rust#70705 may be a good fit. It adds a new trait that is automatically implemented by the compiler for all types.

@spastorino
Copy link
Member Author

@spastorino One thing that would be helpful is if (when you have time) you could add for each link what you think is to be learned from that PR.

Yes, will do at some point :).

@jyn514
Copy link
Member

jyn514 commented Oct 12, 2020

There's a work in progress list of these at https://hackmd.io/xD2fQk_cT_ui6Nt40jHPwA?edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants