Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to latest beta bootstrap compiler #99540

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

Mark-Simulacrum
Copy link
Member

Hopefully this will address #99538, but I'm not sure we can confirm that without rolling it out. Should be safe in general, so likely little risk to just landing this.

@rust-highfive
Copy link
Collaborator

r? @jyn514

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 21, 2022
@jyn514 jyn514 added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jul 21, 2022
@jyn514
Copy link
Member

jyn514 commented Jul 21, 2022

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Jul 21, 2022

📌 Commit ce9f5f8 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2022
@jyn514
Copy link
Member

jyn514 commented Jul 21, 2022

@bors p=20

Let's land this ahead of rollups so people start using it sooner; we only have ~2 weeks left in the cycle

@bors
Copy link
Contributor

bors commented Jul 21, 2022

⌛ Testing commit ce9f5f8 with merge 039a6ad...

@bors
Copy link
Contributor

bors commented Jul 21, 2022

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing 039a6ad to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 21, 2022
@bors bors merged commit 039a6ad into rust-lang:master Jul 21, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 21, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (039a6ad): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
2.4% 2.4% 2
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) N/A N/A 0

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change

  2. number of relevant changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants