Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EntryKind from metadata. #98960

Merged
merged 13 commits into from
Sep 1, 2022
Merged

Remove EntryKind from metadata. #98960

merged 13 commits into from
Sep 1, 2022

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Jul 5, 2022

This PR continues the refactor of metadata emission to be more systematic, iterating on definitions and filtering based on each definition's DefKind. This allows to remove the large EntryKind enum, replaced by linear tables in metadata.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 5, 2022
@cjgillot
Copy link
Contributor Author

cjgillot commented Jul 5, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 5, 2022
@bors
Copy link
Contributor

bors commented Jul 5, 2022

⌛ Trying commit aa7c0b72385fda97913f98749ecba4d05b3e6465 with merge a4011cb6eef91e3830bdf2f739c3b5140ce6720a...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Jul 5, 2022

💔 Test failed - checks-actions

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 5, 2022
@cjgillot
Copy link
Contributor Author

cjgillot commented Jul 5, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Contributor

bors commented Jul 5, 2022

⌛ Trying commit aa7c0b72385fda97913f98749ecba4d05b3e6465 with merge d39a35a69b824686f9f79ec1e99fa347a28d685f...

@bors
Copy link
Contributor

bors commented Jul 5, 2022

☀️ Try build successful - checks-actions
Build commit: d39a35a69b824686f9f79ec1e99fa347a28d685f (d39a35a69b824686f9f79ec1e99fa347a28d685f)

@rust-timer
Copy link
Collaborator

Queued d39a35a69b824686f9f79ec1e99fa347a28d685f with parent 41ad4d9, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d39a35a69b824686f9f79ec1e99fa347a28d685f): comparison url.

Instruction count

  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)
0.6% 2.6% 55
Regressions 😿
(secondary)
2.0% 8.4% 38
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
-1.3% -2.2% 9
All 😿🎉 (primary) 0.6% 2.6% 55

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)
2.3% 4.9% 85
Regressions 😿
(secondary)
4.4% 8.1% 84
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
-2.6% -3.2% 12
All 😿🎉 (primary) 2.3% 4.9% 85

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
3.0% 5.8% 16
Improvements 🎉
(primary)
-3.4% -3.4% 1
Improvements 🎉
(secondary)
-3.9% -6.1% 10
All 😿🎉 (primary) -3.4% -3.4% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2 3

  2. number of relevant changes 2 3

@rustbot rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 6, 2022
@cjgillot
Copy link
Contributor Author

cjgillot commented Jul 6, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 6, 2022
@bors
Copy link
Contributor

bors commented Jul 6, 2022

⌛ Trying commit adb0576b6c900e8dc7f2272bc0ff50afdde590b9 with merge 46ef832c457b61f5d20f548ba382df88edb88f58...

@bjorn3
Copy link
Member

bjorn3 commented Jul 6, 2022

Last perf run suggests that both the crate metadata and the dep graph got bigger.

@bors
Copy link
Contributor

bors commented Jul 6, 2022

☀️ Try build successful - checks-actions
Build commit: 46ef832c457b61f5d20f548ba382df88edb88f58 (46ef832c457b61f5d20f548ba382df88edb88f58)

@rust-timer
Copy link
Collaborator

Queued 46ef832c457b61f5d20f548ba382df88edb88f58 with parent 5b8cf49, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (46ef832c457b61f5d20f548ba382df88edb88f58): comparison url.

Instruction count

  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)
0.5% 0.7% 11
Regressions 😿
(secondary)
0.7% 0.9% 6
Improvements 🎉
(primary)
-0.5% -0.5% 1
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) 0.5% 0.7% 12

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)
2.5% 4.6% 101
Regressions 😿
(secondary)
4.9% 11.1% 87
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
-2.3% -2.5% 4
All 😿🎉 (primary) 2.5% 4.6% 101

Cycles

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)
2.8% 2.8% 1
Regressions 😿
(secondary)
3.2% 3.4% 3
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) 2.8% 2.8% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2 3

  2. number of relevant changes 2 3

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 6, 2022
@Mark-Simulacrum Mark-Simulacrum removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2022
@bors
Copy link
Contributor

bors commented Aug 29, 2022

☔ The latest upstream changes (presumably #101152) made this pull request unmergeable. Please resolve the merge conflicts.

@estebank
Copy link
Contributor

estebank commented Sep 1, 2022

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Sep 1, 2022

📌 Commit 60a052f has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2022
@bors
Copy link
Contributor

bors commented Sep 1, 2022

⌛ Testing commit 60a052f with merge 2e35f95...

@bors
Copy link
Contributor

bors commented Sep 1, 2022

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 2e35f95 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 1, 2022
@bors bors merged commit 2e35f95 into rust-lang:master Sep 1, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 1, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2e35f95): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.4% [1.1%, 1.7%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
1.4% [0.5%, 2.3%] 9
Regressions ❌
(secondary)
3.0% [1.5%, 8.8%] 68
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.9% [-6.2%, -2.3%] 7
All ❌✅ (primary) 1.4% [0.5%, 2.3%] 9

Cycles

This benchmark run did not return any relevant results for this metric.

Footnotes

  1. the arithmetic mean of the percent change 2

  2. number of relevant changes 2

@rustbot rustbot removed the perf-regression Performance regression. label Sep 1, 2022
@cjgillot cjgillot deleted the entry-kind branch September 2, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants