Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #98923

Closed
wants to merge 12 commits into from
Closed

Commits on Jun 5, 2022

  1. Configuration menu
    Copy the full SHA
    b96d1e4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cb7cd97 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2022

  1. Configuration menu
    Copy the full SHA
    ce9e834 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2022

  1. Configuration menu
    Copy the full SHA
    f68e46b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b9d4b13 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    919b708 View commit details
    Browse the repository at this point in the history
  4. fix mir-opt tests

    TaKO8Ki committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    0330f8b View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. ⬆️ rust-analyzer

    lnicola committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    170b173 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#97712 - RalfJung:untyped, r=scottmcm

    ptr::copy and ptr::swap are doing untyped copies
    
    The consensus in rust-lang#63159 seemed to be that these operations should be "untyped", i.e., they should treat the data as raw bytes, should work when these bytes violate the validity invariant of `T`, and should exactly preserve the initialization state of the bytes that are being copied. This is already somewhat implied by the description of "copying/swapping size*N bytes" (rather than "N instances of `T`").
    
    The implementations mostly already work that way (well, for LLVM's intrinsics the documentation is not precise enough to say what exactly happens to poison, but if this ever gets clarified to something that would *not* perfectly preserve poison, then I strongly assume there will be some way to make a copy that *does* perfectly preserve poison). However, I had to adjust `swap_nonoverlapping`; after `@scottmcm's` [recent changes](rust-lang#94212), that one (sometimes) made a typed copy. (Note that `mem::swap`, which works on mutable references, is unchanged. It is documented as "swapping the values at two mutable locations", which to me strongly indicates that it is indeed typed. It is also safe and can rely on `&mut T` pointing to a valid `T` as part of its safety invariant.)
    
    On top of adding a test (that will be run by Miri), this PR then also adjusts the documentation to indeed stably promise the untyped semantics. I assume this means the PR has to go through t-libs (and maybe t-lang?) FCP.
    
    Fixes rust-lang#63159
    Dylan-DPC committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    9c66294 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#98519 - TaKO8Ki:add-head-span-field-to-item…

    …-and-impl-item, r=cjgillot
    
    Replace some `guess_head_span` with `def_span`
    
    This patch fixes a part of rust-lang#97417.
    r? `@cjgillot`
    Dylan-DPC committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    9b2c841 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#98856 - GuillaumeGomez:rustdoc-test-rm-fixm…

    …e, r=Dylan-DPC
    
    Remove FIXME from rustdoc intra-doc test
    
    Removed the FIXME.
    
    For the `extern crate`, even if `pub` exported, its documentation wasn't rendered so there is no point in keeping it.
    
    r? `@notriddle`
    Dylan-DPC committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    dd4d4bf View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#98913 - lnicola:rust-analyzer-2022-07-05, r…

    …=lnicola
    
    ⬆️ rust-analyzer
    
    r? `@ghost`
    Dylan-DPC committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    10e95a6 View commit details
    Browse the repository at this point in the history