-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a documentation problem issue template #98812
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
Should this capture the Rust version in the template too? I can see the appeal of using a very minimal template instead though. |
I don't..think that will be quite useful? No point in reporting a doc problem that happened a release or two ago but fixed on latest :D Although I think I might be misunderstanding what you meant by that |
My thought was that you want to be able to check that the problem wasn't already fixed by another change that forgot to mention the issue. But I suppose that because doc issues are almost always trivial to verify, it's really not worth it. |
@bors r+ rollup Seems like a good start, and we can always iterate in the future. Thanks! |
📌 Commit de9b1da has been approved by |
I'm wondering if it might be helpful to direct the user to the appropriate repo in the comment. Documentation lives all over the place, and going through the rigamarole of having them close and reopen can be annoying. I can transfer issues between some repos, but not all of them. For example, it could say: Some docs have their own dedicated issue trackers. If the issue is for one of the following, please consider filing the issue in the corresponding tracker:
All other documentation issues should be filed here (including The Standard Library, The Rustc Book, The Rustdoc Book, The Rust Unstable Book, and anything else). That might be a bit too much or overwhelming, so I'm not sure if it makes sense. I only need to transfer an issue about once a month, so it doesn't happen too often. Also, most of those docs have links directly to their GitHub repos, so most users seem to be able to find their way. What do you think? |
Rollup of 6 pull requests Successful merges: - rust-lang#98701 (Add regression test for rust-lang#50439) - rust-lang#98715 (add ice test for rust-lang#97047) - rust-lang#98753 (Fix `x dist rust-dev` on a fresh checkout) - rust-lang#98805 (Add rust-lang#95469 to the release notes) - rust-lang#98812 (feat: Add a documentation problem issue template) - rust-lang#98819 (update Miri) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
I personally like those links quite a bit, but I like long issue templates much more than the average user 😆 Perhaps list what does fit here, and then link to an external page for "everything else"? |
We could have the list in a comment in the template, so it wouldn't be shown in the render =) |
Fixes #98722 :)