Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a documentation problem issue template #98812

Merged
merged 1 commit into from
Jul 2, 2022
Merged

feat: Add a documentation problem issue template #98812

merged 1 commit into from
Jul 2, 2022

Conversation

gimbling-away
Copy link
Contributor

Fixes #98722 :)

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 2, 2022
@alice-i-cecile
Copy link

Should this capture the Rust version in the template too? I can see the appeal of using a very minimal template instead though.

@gimbling-away
Copy link
Contributor Author

Should this capture the Rust version in the template too? I can see the appeal of using a very minimal template instead though.

I don't..think that will be quite useful? No point in reporting a doc problem that happened a release or two ago but fixed on latest :D

Although I think I might be misunderstanding what you meant by that

@alice-i-cecile
Copy link

My thought was that you want to be able to check that the problem wasn't already fixed by another change that forgot to mention the issue.

But I suppose that because doc issues are almost always trivial to verify, it's really not worth it.

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

Seems like a good start, and we can always iterate in the future. Thanks!

@bors
Copy link
Contributor

bors commented Jul 2, 2022

📌 Commit de9b1da has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2022
@ehuss
Copy link
Contributor

ehuss commented Jul 2, 2022

I'm wondering if it might be helpful to direct the user to the appropriate repo in the comment. Documentation lives all over the place, and going through the rigamarole of having them close and reopen can be annoying. I can transfer issues between some repos, but not all of them.

For example, it could say:

Some docs have their own dedicated issue trackers. If the issue is for one of the following, please consider filing the issue in the corresponding tracker:

All other documentation issues should be filed here (including The Standard Library, The Rustc Book, The Rustdoc Book, The Rust Unstable Book, and anything else).


That might be a bit too much or overwhelming, so I'm not sure if it makes sense. I only need to transfer an issue about once a month, so it doesn't happen too often. Also, most of those docs have links directly to their GitHub repos, so most users seem to be able to find their way. What do you think?

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 2, 2022
Rollup of 6 pull requests

Successful merges:

 - rust-lang#98701 (Add regression test for rust-lang#50439)
 - rust-lang#98715 (add ice test for rust-lang#97047)
 - rust-lang#98753 (Fix `x dist rust-dev` on a fresh checkout)
 - rust-lang#98805 (Add rust-lang#95469 to the release notes)
 - rust-lang#98812 (feat: Add a documentation problem issue template)
 - rust-lang#98819 (update Miri)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2dbbf8c into rust-lang:master Jul 2, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 2, 2022
@alice-i-cecile
Copy link

I personally like those links quite a bit, but I like long issue templates much more than the average user 😆

Perhaps list what does fit here, and then link to an external page for "everything else"?

@gimbling-away
Copy link
Contributor Author

I personally like those links quite a bit, but I like long issue templates much more than the average user laughing

Perhaps list what does fit here, and then link to an external page for "everything else"?

We could have the list in a comment in the template, so it wouldn't be shown in the render =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

This repository has no issue template for documentation problems
7 participants