Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap: illumos platform flags for split-debuginfo #98763

Merged
merged 1 commit into from
Jul 2, 2022
Merged

bootstrap: illumos platform flags for split-debuginfo #98763

merged 1 commit into from
Jul 2, 2022

Conversation

citrus-it
Copy link
Contributor

Bootstrap currently provides -Zunstable-options for platforms
when using split debuginfo - this commit adds it for the illumos
target too.

@citrus-it
bootstrap: illumos platform flags for split-debuginfo
5122bb5 
Bootstrap currently provides `-Zunstable-options` for platforms
when using split debuginfo - this commit adds it for the illumos
target too.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 1, 2022
@citrus-it
Copy link
Contributor Author

For reference, here is what I see when doing a build of rust 1.62.0 on illumos, without this patch:

error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `/data/omnios-build/omniosorg/r151042/_extra/rust-1.62.0/rustc-1.62.0-src/build/bootstrap/debug/rustc - --crate-name ___ --print=file-names --cfg=bootstrap -Csymbol-mangling-version=v0 -Zmacro-backtrace -Clink-args=-Wl,-z,origin '-Clink-args=-Wl,-rpath,$ORIGIN/../lib' -Csplit-debuginfo=off -Ztls-model=initial-exec --target x86_64-unknown-illumos --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=cfg` (exit status: 1)
  --- stderr
  error: `-Csplit-debuginfo` is unstable on this platform

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 2, 2022

📌 Commit 5122bb5 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Jul 2, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 2, 2022
@bors
Auto merge of rust-lang#98802 - Dylan-DPC:rollup-u6mwx27, r=Dylan-DPC
aedf78e 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#98639 (Factor out `hir::Node::Binding`)
 - rust-lang#98653 (Add regression test for rust-lang#79494)
 - rust-lang#98763 (bootstrap: illumos platform flags for split-debuginfo)
 - rust-lang#98766 (cleanup mir visitor for `rustc::pass_by_value`)
 - rust-lang#98783 (interpret: make a comment less scary)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5fe0997 into rust-lang:master Jul 2, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
5 participants
@citrus-it @rust-highfive @Mark-Simulacrum @bors @rustbot