Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RELEASES.md #98734

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Jun 30, 2022

Clarify that flow sensitive checks now understand that visibly
uninhabited call expressions never return.

The change influences checks of reachable and unreachable code alike,
not just dead code like previous wording would imply.

cc @Kixunil

Clarify that flow sensitive checks now understand that *visibly*
uninhabited call expressions never return.

The change influences checks of reachable and unreachable code alike,
not just dead code like previous wording would imply.
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 30, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 30, 2022

📌 Commit debee1e has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2022
@Kixunil
Copy link
Contributor

Kixunil commented Jun 30, 2022

Thanks, though I meant updating the description of #93313

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 30, 2022
…otes, r=Mark-Simulacrum

Update RELEASES.md

Clarify that flow sensitive checks now understand that *visibly*
uninhabited call expressions never return.

The change influences checks of reachable and unreachable code alike,
not just dead code like previous wording would imply.

cc `@Kixunil`
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 1, 2022
…askrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#98610 (fix `emit_inference_failure_err` ICE)
 - rust-lang#98640 (Let rust-analyzer ship on stable, non-preview)
 - rust-lang#98686 (add ice test for 46511)
 - rust-lang#98727 (rustdoc: filter '_ lifetimes from ty::PolyTraitRef)
 - rust-lang#98729 (clarify that ExactSizeIterator::len returns the remaining length)
 - rust-lang#98733 (Request to be notified of MIR changes)
 - rust-lang#98734 (Update RELEASES.md)
 - rust-lang#98745 (Add a `--build-dir` flag to rustbuild)
 - rust-lang#98749 (Add macro_rules! rustdoc change to 1.62 relnotes)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c4acd06 into rust-lang:master Jul 1, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 1, 2022
@tmiasko tmiasko deleted the uninhabited-calls-release-notes branch July 7, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants