Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore invalid-punct-ident-1.rs proc-macro test on stage1 #98659

Closed
wants to merge 1 commit into from

Conversation

lqd
Copy link
Member

@lqd lqd commented Jun 29, 2022

invalid-punct-ident-1.rs has been failing on stage1, which impacts people's workflows.

More details in this zulip thread

r? @eddyb

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 29, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 29, 2022
@lqd
Copy link
Member Author

lqd commented Jun 29, 2022

Note: a better fix is coming, we'll close this PR when eddy opens their one.

@eddyb
Copy link
Member

eddyb commented Jun 29, 2022

Sorry for the race, my PR is #98660 (I waited longer since I wanted to confirm both stage1 and stage2 pass).

@eddyb eddyb closed this Jun 29, 2022
@lqd lqd deleted the ignore-proc-macro-test branch June 29, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants