Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcore tests: avoid int2ptr casts #98587

Merged
merged 1 commit into from
Jun 28, 2022
Merged

libcore tests: avoid int2ptr casts #98587

merged 1 commit into from
Jun 28, 2022

Conversation

RalfJung
Copy link
Member

We don't need any of these pointers to actually be dereferenceable so using ptr::invalid should be fine. And then we can run Miri with strict provenance enforcement on the tests.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 27, 2022
@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @thomcc

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 27, 2022
@thomcc
Copy link
Member

thomcc commented Jun 27, 2022

lgtm

@bors r+

@bors
Copy link
Contributor

bors commented Jun 27, 2022

📌 Commit 8c977cf has been approved by thomcc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2022
@RalfJung RalfJung mentioned this pull request Jun 27, 2022
Merged
@RalfJung

This comment was marked as outdated.

Sign in to view
@RalfJung

This comment was marked as outdated.

Sign in to view
@RalfJung
Copy link
Member Author

@bors rollup=always

@thomcc
Copy link
Member

thomcc commented Jun 27, 2022

It's not always ideal to rollup tests I think, since sometimes they fail in rollup. But it also doesn't really matter.

@RalfJung
Copy link
Member Author

Yeah but this seems like a change where I trust PR CI. And we need rollups right now.^^

@matthiaskrgr matthiaskrgr mentioned this pull request Jun 27, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 27, 2022
@bors
Auto merge of rust-lang#98591 - matthiaskrgr:rollup-7dok1wq, r=matthi…
7f08d04 
…askrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#98331 (Fix rustdoc argument error)
 - rust-lang#98506 (Fix span issues in object safety suggestions)
 - rust-lang#98563 (interpret: refactor allocation info query)
 - rust-lang#98576 (small regions refactoring)
 - rust-lang#98577 (Fix "kind" for associated types in trait implementations in rustdoc JSON)
 - rust-lang#98578 (Remove eddyb from miri failure pings)
 - rust-lang#98579 (liballoc tests: avoid int2ptr cast)
 - rust-lang#98581 (Add triagebot mentions.)
 - rust-lang#98587 (libcore tests: avoid int2ptr casts)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f266821 into rust-lang:master Jun 28, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jun 28, 2022
@RalfJung RalfJung deleted the core-tests branch June 28, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
5 participants
@RalfJung @rust-highfive @thomcc @bors @rustbot