Do not fetch HIR to compute variances.

[cjgillot]

Everything can be done using higher-level queries. This simplifies the code, and should allow better incremental caching.

[rust-highfive]

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

[cjgillot]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 824463153b5c29b6f6b87fc630a999af6a398d3e with merge 6fa6139b8a1f9ac0c2cdb04101c5b2c1258c21d5...

[bors]

☀️ Try build successful - checks-actions
Build commit: 6fa6139b8a1f9ac0c2cdb04101c5b2c1258c21d5 (6fa6139b8a1f9ac0c2cdb04101c5b2c1258c21d5)

[rust-timer]

Queued 6fa6139b8a1f9ac0c2cdb04101c5b2c1258c21d5 with parent 1aabd8a, future comparison URL.

[rust-timer]

Finished benchmarking commit (6fa6139b8a1f9ac0c2cdb04101c5b2c1258c21d5): comparison url.

Instruction count

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 🎉 relevant improvement found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-0.9%	-0.9%	1
All 😿🎉 (primary)	N/A	N/A	0

Max RSS (memory usage)

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 😿 relevant regression found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	4.1%	4.1%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

Cycles

Results

• Primary benchmarks: mixed results
• Secondary benchmarks: 😿 relevant regressions found

	mean1	max	count2
Regressions 😿 (primary)	3.6%	3.6%	1
Regressions 😿 (secondary)	2.5%	2.7%	3
Improvements 🎉 (primary)	-3.0%	-3.0%	1
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	0.3%	3.6%	2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³

[wesleywiser]

@bors r+

[bors]

📌 Commit 3df10a2 has been approved by wesleywiser

[bors]

⌛ Testing commit 3df10a2 with merge fac8fa5...

[bors]

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing fac8fa5 to master...

[rust-timer]

Finished benchmarking commit (fac8fa5): comparison url.

Instruction count

• Primary benchmarks: 😿 relevant regressions found
• Secondary benchmarks: 😿 relevant regressions found

	mean1	max	count2
Regressions 😿 (primary)	0.8%	1.0%	7
Regressions 😿 (secondary)	1.5%	2.4%	10
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	0.8%	1.0%	7

Max RSS (memory usage)

Results

• Primary benchmarks: 🎉 relevant improvement found
• Secondary benchmarks: no relevant changes found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-0.1%	-0.1%	1
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-0.1%	-0.1%	1

Cycles

Results

• Primary benchmarks: 😿 relevant regression found
• Secondary benchmarks: 😿 relevant regressions found

	mean1	max	count2
Regressions 😿 (primary)	2.2%	2.2%	1
Regressions 😿 (secondary)	2.8%	3.2%	8
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	2.2%	2.2%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³

[Mark-Simulacrum]

Per #98925 (comment) these results are likely noise, so dropping the regression label.