Rename `<*{mut,const} T>::as_{const,mut}` to `cast_` #98174

Kixunil · 2022-06-16T17:53:46Z

This renames the methods to use the cast_ prefix instead of as_ to
make it more readable and avoid confusion with <*mut T>::as_mut()
which is unsafe and returns a reference.

Sorry, didn't notice ACP process exists, opened rust-lang/libs-team#51

See #92675

rust-highfive · 2022-06-16T17:53:49Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

rust-highfive · 2022-06-16T17:53:51Z

r? @scottmcm

(rust-highfive has picked a reviewer for you, use r? to override)

Kixunil · 2022-06-16T17:54:41Z

@rustbot label +T-libs-api -T-libs

library/core/src/ptr/const_ptr.rs

scottmcm · 2022-06-16T18:24:30Z

I marked this as blocked because ACP, though I'm new to ACP too so I'm not sure what the process is here. I probably would have been fine with just approving it because nightly, but let's see what the libs-api folks say.

CryZe · 2022-06-16T19:08:11Z

cast_mut reads a lot worse to me. When I opened this PR not knowing what it's about, I was expecting cast_mut to be a variant of cast() (which casts from *T to *U) that only applies to mut pointers or something (like lots of other methods that have a _mut suffix). It would read a lot better as cast_to_mut or just to_mut.

Kixunil · 2022-06-17T07:58:47Z

@CryZe good point! to_mut/to_const sounds good, I'll change it if others agree.

josephlr · 2022-06-17T08:19:20Z

@CryZe good point! to_mut/to_const sounds good, I'll change it if others agree.

As someone who liked the cast_mut / cast_const naming, I think the to_mut/to_const naming is better

scottmcm · 2022-07-20T19:20:28Z

With the ACP decided, please update this PR and I'll approve it!

@rustbot author

rustbot · 2022-07-21T12:27:27Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

Kixunil · 2022-07-21T14:10:01Z

@rustbot ready

library/core/src/ptr/mut_ptr.rs

This renames the methods to use the `cast_` prefix instead of `as_` to make it more readable and avoid confusion with `<*mut T>::as_mut()` which is `unsafe` and returns a reference. See rust-lang#92675

scottmcm · 2022-07-21T17:36:33Z

Thanks for the idea & PR!

@bors r+ rollup

bors · 2022-07-21T17:36:35Z

📌 Commit eb5acc9 has been approved by scottmcm

It is now in the queue for this repository.

…cast, r=scottmcm Rename `<*{mut,const} T>::as_{const,mut}` to `cast_` This renames the methods to use the `cast_` prefix instead of `as_` to make it more readable and avoid confusion with `<*mut T>::as_mut()` which is `unsafe` and returns a reference. Sorry, didn't notice ACP process exists, opened rust-lang/libs-team#51 See rust-lang#92675

Rollup of 6 pull requests Successful merges: - rust-lang#98174 (Rename `<*{mut,const} T>::as_{const,mut}` to `cast_`) - rust-lang#98868 (Fix unreachable coverage generation for inlined functions) - rust-lang#99393 (feat: omit suffixes in const generics (e.g. `1_i32`)) - rust-lang#99423 (Group CSS font rule) - rust-lang#99539 (Improve suggestions for returning binding) - rust-lang#99579 (Add same warning to Result::expect as Result::unwrap) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned scottmcm Jun 16, 2022

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 16, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 16, 2022

rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 16, 2022

Kixunil mentioned this pull request Jun 16, 2022

ACP: change as_{mut,const} on pointers to cast_{mut,const} rust-lang/libs-team#51

Closed

scottmcm reviewed Jun 16, 2022

View reviewed changes

library/core/src/ptr/const_ptr.rs Show resolved Hide resolved

scottmcm removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Jul 20, 2022

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 20, 2022

Kixunil force-pushed the rename_ptr_as_mut_const_to_cast branch from f1deafa to 5934cab Compare July 21, 2022 12:27

Kixunil requested a review from scottmcm July 21, 2022 14:01

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 21, 2022

scottmcm reviewed Jul 21, 2022

View reviewed changes

library/core/src/ptr/mut_ptr.rs Show resolved Hide resolved

scottmcm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2022

Rename <*{mut,const} T>::as_{const,mut} to cast_

eb5acc9

This renames the methods to use the `cast_` prefix instead of `as_` to make it more readable and avoid confusion with `<*mut T>::as_mut()` which is `unsafe` and returns a reference. See rust-lang#92675

Kixunil force-pushed the rename_ptr_as_mut_const_to_cast branch from 5934cab to eb5acc9 Compare July 21, 2022 16:30

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 21, 2022

This was referenced Jul 22, 2022

Rollup of 6 pull requests #99590

Closed

Rollup of 6 pull requests #99592

Merged

bors merged commit ad31d5c into rust-lang:master Jul 22, 2022

rustbot added this to the 1.64.0 milestone Jul 22, 2022

Kixunil deleted the rename_ptr_as_mut_const_to_cast branch July 22, 2022 09:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename `<*{mut,const} T>::as_{const,mut}` to `cast_` #98174

Rename `<*{mut,const} T>::as_{const,mut}` to `cast_` #98174

Kixunil commented Jun 16, 2022 •

edited

Loading

rust-highfive commented Jun 16, 2022

rust-highfive commented Jun 16, 2022

Kixunil commented Jun 16, 2022

scottmcm commented Jun 16, 2022

CryZe commented Jun 16, 2022 •

edited

Loading

Kixunil commented Jun 17, 2022

josephlr commented Jun 17, 2022

scottmcm commented Jul 20, 2022 •

edited

Loading

rustbot commented Jul 21, 2022

Kixunil commented Jul 21, 2022

scottmcm commented Jul 21, 2022

bors commented Jul 21, 2022

Rename <*{mut,const} T>::as_{const,mut} to cast_ #98174

Rename <*{mut,const} T>::as_{const,mut} to cast_ #98174

Conversation

Kixunil commented Jun 16, 2022 • edited Loading

rust-highfive commented Jun 16, 2022

rust-highfive commented Jun 16, 2022

Kixunil commented Jun 16, 2022

scottmcm commented Jun 16, 2022

CryZe commented Jun 16, 2022 • edited Loading

Kixunil commented Jun 17, 2022

josephlr commented Jun 17, 2022

scottmcm commented Jul 20, 2022 • edited Loading

rustbot commented Jul 21, 2022

Kixunil commented Jul 21, 2022

scottmcm commented Jul 21, 2022

bors commented Jul 21, 2022

Rename `<*{mut,const} T>::as_{const,mut}` to `cast_` #98174

Rename `<*{mut,const} T>::as_{const,mut}` to `cast_` #98174

Kixunil commented Jun 16, 2022 •

edited

Loading

CryZe commented Jun 16, 2022 •

edited

Loading

scottmcm commented Jul 20, 2022 •

edited

Loading