Emscripten target: replace -g4 with -g, and -g3 with --profiling-funcs #98150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
sbc100
reviewed
Jun 15, 2022
sbc100
approved these changes
Jun 15, 2022
|
@bors r=sbc100 |
|
📌 Commit f864c86b901ed069adb252c1dd11f67d2f847f86 has been approved by |
bors
added
S-waiting-on-bors
|
Huh, preferably this commit would get squashed and the title edited to "replace -g4 with -g, and -g3 with --profiling-funcs" or something, since the title makes no sense with the code changes now. |
hoodmane
changed the title
|
📌 Commit a2ecf5b has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 18, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#97803 (Impl Termination for Infallible and then make the Result impls of Termination more generic) - rust-lang#97828 (Allow configuring where artifacts are downloaded from) - rust-lang#98150 (Emscripten target: replace -g4 with -g, and -g3 with --profiling-funcs) - rust-lang#98195 (Fix rustdoc json primitive handling) - rust-lang#98205 (Remove a possible unnecessary assignment) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
workingjubilee
added
the
O-emscripten
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emscripten prints the following warning:
@sbc100