Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Don't imply that OsStr on Unix is always UTF-8 #97448

Merged
merged 1 commit into from
May 28, 2022
Merged

docs: Don't imply that OsStr on Unix is always UTF-8 #97448

merged 1 commit into from
May 28, 2022

Conversation

Xiretza
Copy link
Contributor

@Xiretza Xiretza commented May 27, 2022

The methods in OsStrExt consume and return &[u8] and don't perform any UTF-8 checks.

@Xiretza
docs: Don't imply that OsStr on Unix is always UTF-8
2020264 
The methods in `OsStrExt` consume and return `&[u8]` and don't perform
any UTF-8 checks.
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 27, 2022
@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 27, 2022
@Mark-Simulacrum
Copy link
Member

r? @joshtriplett -- but I don't personally think this needs T-libs-api approval since I don't think we could (or would want to) do anything different here.

@joshtriplett
Copy link
Member

I don't think this needs a full team approval either; OsStr on UNIX is already known to be a bag of bytes, whether it comes from the system or a user conversion.

@bors r+

@bors
Copy link
Contributor

bors commented May 28, 2022

📌 Commit 2020264 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 28, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request May 28, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 28, 2022
@bors
Auto merge of rust-lang#97476 - Dylan-DPC:rollup-t53nxoe, r=Dylan-DPC
19abca1 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#94640 (Partially stabilize `(const_)slice_ptr_len` feature by stabilizing `NonNull::len`)
 - rust-lang#97034 (Implement `Hash` for `core::alloc::Layout`)
 - rust-lang#97327 (macros: introduce `fluent_messages` macro )
 - rust-lang#97448 (docs: Don't imply that OsStr on Unix is always UTF-8)
 - rust-lang#97466 ([bootstrap] Move `sanitize_sh` from `dist` to `install`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 529fcb5 into rust-lang:master May 28, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 28, 2022
@Xiretza Xiretza deleted the os-str-unix-doc branch August 18, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Xiretza @rust-highfive @Mark-Simulacrum @joshtriplett @bors @rustbot