library/std: Bump compiler_builtins #97435

Patryk27 · 2022-05-26T19:13:30Z

Some neat changes include faster float conversions & fixes for AVR 🙂

(note that's it's my first time upgrading compiler_builtins, so I'm not 100% sure if bumping library/std/Cargo.toml is enough; certainly seems to be so, though.)

rust-highfive · 2022-05-26T19:13:33Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

rust-highfive · 2022-05-26T19:13:34Z

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

Dylan-DPC · 2022-05-27T11:29:40Z

@bors r+

bors · 2022-05-27T11:29:41Z

📌 Commit 7005f24 has been approved by Dylan-DPC

…Dylan-DPC library/std: Bump compiler_builtins Some neat changes include faster float conversions & fixes for AVR 🙂 (note that's it's my first time upgrading `compiler_builtins`, so I'm not 100% sure if bumping `library/std/Cargo.toml` is enough; certainly seems to be so, though.)

bors · 2022-05-29T11:16:01Z

⌛ Testing commit 7005f24 with merge 23c5bb78d30b07cf0f347f923509d5e69b7562dd...

bors · 2022-05-29T12:00:24Z

💔 Test failed - checks-actions

rust-log-analyzer · 2022-05-29T12:09:21Z

The job i686-mingw-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [ui] src/test\ui\runtime\backtrace-debuginfo.rs stdout ----

error: test run failed!
status: exit code: 101
command: PATH="D:\a\rust\rust\build\i686-pc-windows-gnu\stage2\lib\rustlib\i686-pc-windows-gnu\lib;D:\a\rust\rust\build\i686-pc-windows-gnu\stage0-bootstrap-tools\i686-pc-windows-gnu\release\deps;D:\a\rust\rust\build\i686-pc-windows-gnu\stage0\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\mingw32\bin;C:\hostedtoolcache\windows\Python\3.10.4\x64\Scripts;C:\hostedtoolcache\windows\Python\3.10.4\x64;C:\msys64\usr\bin;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\cf-cli;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\2.7.5\x64;C:\cabal\bin;C:\ghcup\bin;C:\tools\ghc-9.2.2\bin;C:\Program Files\dotnet;C:\mysql\bin;C:\Program Files\R\R-4.2.0\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\hostedtoolcache\windows\go\1.17.10\x64\bin;C:\hostedtoolcache\windows\Python\3.7.9\x64\Scripts;C:\hostedtoolcache\windows\Python\3.7.9\x64;C:\hostedtoolcache\windows\Ruby\2.5.9\x64\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.332-9\x64\bin;C:\npm\prefix;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\Program Files\Eclipse Foundation\jdk-8.0.302.8-hotspot\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\ProgramData\Chocolatey\bin;C:\Program Files\Docker;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\dotnet;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\Microsoft SQL Server\110\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\140\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\nodejs;C:\Program Files\OpenSSL\bin;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\TortoiseSVN\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.5\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\SeleniumWebDrivers\ChromeDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files (x86)\Google\Cloud SDK\google-cloud-sdk\bin;C:\Program Files (x86)\Microsoft BizTalk Server;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\test\\ui\\runtime\\backtrace-debuginfo\\a.exe"
---------------------------------------
trace does not match position list
trace does not match position list
still need to find ["backtrace-debuginfo.rs:183"]
--- stdout
backtrace-debuginfo-aux.rs:6
backtrace-debuginfo.rs:82
backtrace-debuginfo.rs:119
backtrace-debuginfo.rs:119
backtrace-debuginfo.rs:183

--- stderr
test case 2
thread 'main' panicked at 'explicit panic', D:\a\rust\rust\src/test\ui\runtime\backtrace-debuginfo.rs:83:9
stack backtrace:
   0: 0x71b94e4e - core::fmt::write::hb3de2e02f973e8b6
   1: 0x71b270f4 - std::io::Write::write_fmt::h638a5c919110df2c
   2: 0x71b367f1 - std::panicking::default_hook::{{closure}}::h8b9dcaf961af952c
   3: 0x71b3652f - std::panicking::default_hook::h85ebe8ff13fbfb91
   4: 0x71b36ed0 - std::panicking::rust_panic_with_hook::h75c2ad14e652bd23
   5:   0x4036b3 - std::panicking::begin_panic::{{closure}}::hb8bd53031aaff874
                       at D:\a\rust\rust\library\std\src\panicking.rs:617:9
   6:   0x4031b5 - std::sys_common::backtrace::__rust_end_short_backtrace::hca95f158e85e3dd1
                       at D:\a\rust\rust\library\std\src\sys_common\backtrace.rs:138:18
   7:   0x403612 - std::panicking::begin_panic::hb8b67146283bf752
                       at D:\a\rust\rust\library\std\src\panicking.rs:616:12
   8:   0x4171fe - backtrace_debuginfo::inner::{{closure}}::h59122acb3b1f10ce
                       at D:\a\rust\rust\src/test\ui\runtime\backtrace-debuginfo.rs:83:9
   9:   0x416beb - backtrace_debuginfo::aux::callback::hce098a2a42e4d40c
  10:   0x416fe0 - backtrace_debuginfo::inner::h68711b0a08793708
                       at D:\a\rust\rust\src/test\ui\runtime\backtrace-debuginfo.rs:82:29
                       at D:\a\rust\rust\src/test\ui\runtime\backtrace-debuginfo.rs:82:29
  11:   0x4175fe - backtrace_debuginfo::outer::h383486e0a6708dcb
                       at D:\a\rust\rust\src/test\ui\runtime\backtrace-debuginfo.rs:119:5
  12:   0x9af798 - <unknown>
  13:   0x405129 - core::ops::function::FnOnce::call_once::h03d8f82ea5ccd7c0
                       at D:\a\rust\rust\library\core\src\ops\function.rs:248:5
  14:   0x4031f1 - std::sys_common::backtrace::__rust_begin_short_backtrace::h17a07543e83addb6
                       at D:\a\rust\rust\library\std\src\sys_common\backtrace.rs:122:18
  15:   0x403273 - std::rt::lang_start::{{closure}}::h4431b2c2d1388e98
                       at D:\a\rust\rust\library\std\src\rt.rs:145:18
  16: 0x71b190f0 - std::rt::lang_start_internal::he2a6984270c0caf1
  17:   0x403250 - std::rt::lang_start::h6cebe39b335281f9
                       at D:\a\rust\rust\library\std\src\rt.rs:144:17
  18:   0x418ab3 - _main
  19:   0x4013e3 - ___tmainCRTStartup
  20: 0x77240419 - <unknown>
  21: 0x77c372fd - <unknown>
  22: 0x77c372cd - <unknown>
--- stderr -------------------------------
--- stderr -------------------------------
thread 'main' panicked at 'found some errors', D:\a\rust\rust\src/test\ui\runtime\backtrace-debuginfo.rs:173:9
------------------------------------------




failures:
    [ui] src/test\ui\runtime\backtrace-debuginfo.rs

test result: FAILED. 13095 passed; 1 failed; 193 ignored; 0 measured; 0 filtered out; finished in 541.61s

Some tests failed in compiletest suite=ui mode=ui host=i686-pc-windows-gnu target=i686-pc-windows-gnu
Build completed unsuccessfully in 0:38:42
make: *** [Makefile:80: ci-mingw-subset-2] Error 1

Mark-Simulacrum · 2022-06-01T01:22:46Z

@bors retry rollup=never (perf impact possible though unlikely)

bors · 2022-06-01T01:49:07Z

⌛ Testing commit 7005f24 with merge 02916c4...

bors · 2022-06-01T04:29:49Z

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing 02916c4 to master...

rust-highfive · 2022-06-01T04:30:16Z

📣 Toolstate changed by #97435!

Tested on commit 02916c4.
Direct link to PR: #97435

🎉 rls on linux: test-fail → test-pass (cc @Xanewok).

@Xanewok

Tested on commit rust-lang/rust@02916c4. Direct link to PR: <rust-lang/rust#97435> 🎉 rls on linux: test-fail → test-pass (cc @Xanewok).

rust-timer · 2022-06-01T05:49:11Z

Finished benchmarking commit (02916c4): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

Primary benchmarks: 🎉 relevant improvement found
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	3.6%	4.7%	3
Improvements 🎉 (primary)	-2.5%	-2.5%	1
Improvements 🎉 (secondary)	-2.7%	-2.7%	1
All 😿🎉 (primary)	-2.5%	-2.5%	1

Cycles

Results

Primary benchmarks: 😿 relevant regressions found
Secondary benchmarks: 🎉 relevant improvement found

	mean¹	max	count²
Regressions 😿 (primary)	2.9%	3.0%	2
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-1.9%	-1.9%	1
All 😿🎉 (primary)	2.9%	3.0%	2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

the arithmetic mean of the percent change ↩ ↩²
number of relevant changes ↩ ↩²

The `compiler-builtins-mangled-names` thingie¹ is no longer needed, since `compiler_builtins` has been improved to avoid pulling the problematic functions: - rust-lang/compiler-builtins#462 - rust-lang/compiler-builtins#466 - rust-lang/rust#97435 ¹ rust-lang/rust#82242

@Patryk27

The `compiler-builtins-mangled-names` thingie¹ is no longer needed, since `compiler_builtins` has been improved to avoid pulling the problematic functions: - rust-lang/compiler-builtins#462 - rust-lang/compiler-builtins#466 - rust-lang/rust#97435 ¹ rust-lang/rust#82242 Suggested-by: @Patryk27 Link: Rahix/avr-hal-template#8

@Patryk27

The `compiler-builtins-mangled-names` thingie¹ is no longer needed, since `compiler_builtins` has been improved to avoid pulling the problematic functions: - rust-lang/compiler-builtins#462 - rust-lang/compiler-builtins#466 - rust-lang/rust#97435 ¹ rust-lang/rust#82242 Suggested-by: @Patryk27 Link: Rahix/avr-hal-template#8

@Patryk27

The `compiler-builtins-mangled-names` thingie¹ is no longer needed, since `compiler_builtins` has been improved to avoid pulling the problematic functions: - rust-lang/compiler-builtins#462 - rust-lang/compiler-builtins#466 - rust-lang/rust#97435 ¹ rust-lang/rust#82242 Suggested-by: @Patryk27 Link: Rahix/avr-hal-template#8

library/std: Bump compiler_builtins

7005f24

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 26, 2022

rust-highfive assigned Mark-Simulacrum May 26, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 26, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 27, 2022

GuillaumeGomez mentioned this pull request May 28, 2022

Rollup of 7 pull requests #97496

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 29, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 1, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 1, 2022

bors merged commit 02916c4 into rust-lang:master Jun 1, 2022

rustbot added this to the 1.63.0 milestone Jun 1, 2022

Patryk27 deleted the bump-compiler-builtins branch June 1, 2022 05:03

Patryk27 mentioned this pull request Jun 14, 2022

Update toolchain, get rid of the std-features hack Rahix/avr-hal-template#8

Merged

Rahix mentioned this pull request Jun 16, 2022

Update toolchain, get rid of the std-features hack Rahix/avr-hal#281

Merged

JohnTitor mentioned this pull request Apr 22, 2023

Rollup of 7 pull requests #110666

Merged

ehuss mentioned this pull request Oct 23, 2023

test ui/backtrace-debuginfo.rs is flaky #117097

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

library/std: Bump compiler_builtins #97435

library/std: Bump compiler_builtins #97435

Patryk27 commented May 26, 2022

rust-highfive commented May 26, 2022

rust-highfive commented May 26, 2022

Dylan-DPC commented May 27, 2022

bors commented May 27, 2022

bors commented May 29, 2022

bors commented May 29, 2022

rust-log-analyzer commented May 29, 2022

Mark-Simulacrum commented Jun 1, 2022

bors commented Jun 1, 2022

bors commented Jun 1, 2022

rust-highfive commented Jun 1, 2022

rust-timer commented Jun 1, 2022

library/std: Bump compiler_builtins #97435

library/std: Bump compiler_builtins #97435

Conversation

Patryk27 commented May 26, 2022

rust-highfive commented May 26, 2022

rust-highfive commented May 26, 2022

Dylan-DPC commented May 27, 2022

bors commented May 27, 2022

bors commented May 29, 2022

bors commented May 29, 2022

rust-log-analyzer commented May 29, 2022

Mark-Simulacrum commented Jun 1, 2022

bors commented Jun 1, 2022

bors commented Jun 1, 2022

rust-highfive commented Jun 1, 2022

rust-timer commented Jun 1, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes