Make outlives::{components,verify} agree

[aliemjay]

fixes #97405

cc @oli-obk this is should fix #95474 (comment)

r? @oli-obk

[aliemjay]

r? @oli-obk

[oli-obk]

Nominating for T-types discussion:

fn opaque<F>(_: F) -> impl Iterator { b"".iter() }
fn assert_static<T: 'static>(_: T) {}

fn good_generic_fn<T>() {
    // proving `<OpaqueTy<type_of(async {})> as Iterator>::Item: 'static`
    // somehow requires `T: 'static`.
    assert_static(opaque(async {}).next());
    assert_static(opaque(|| {}).next());
    assert_static(opaque(opaque(async {}).next()).next());
}

does not compile right now, because the T of good_generic_fn is inherited by generators and closures, even if they do not capture any types that relate to T. This PR does not change that, but it instead adjusts the algorithm figuring out which types and lifetimes must be considered for an outlives bound to only look at captured things in the generators or closures.

This scheme already works on stable for simpler cases, but in associated types it breaks down. Thus I nominate for T-types instead of T-lang, since imo this is just-an-impl-bug and the behaviour intended by the lang team.

[aliemjay]

a less contrived example that should be pass now:

fn from_fn<F>(_: F) -> impl IntoIterator<Item = u8> { [] }

fn generic_fn<T>() -> Box<dyn Iterator<Item = u8>> {
    Box::new(from_fn(|| {}).into_iter())
    //~^ ERROR the associated type `<impl IntoIterator<Item = u8> as IntoIterator>::IntoIter` may not live long enough
}

[aliemjay]

@rustbot review
@rustbot label S-waiting-on-team

[oli-obk]

Let's see if this opens a zulip thread automagically

[aliemjay]

oli-obk is in vacation, so
r? @nikomatsakis

@nikomatsakis choosed you because you recently touched VerifyBounds and types tests, and this PR basically fixes malformed verify bounds for projection tys. Feel free to reassign if you like.

[oli-obk]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit de2750fde4f48b772a0f60ebfa69192ece57c805 with merge adb581d2e9a6bc04d25a117528c5bb41de56d059...

[bors]

☀️ Try build successful - checks-actions
Build commit: adb581d2e9a6bc04d25a117528c5bb41de56d059 (adb581d2e9a6bc04d25a117528c5bb41de56d059)

[rust-timer]

Queued adb581d2e9a6bc04d25a117528c5bb41de56d059 with parent ebe184a, future comparison URL.

[rust-timer]

Finished benchmarking commit (adb581d2e9a6bc04d25a117528c5bb41de56d059): comparison url.

Instruction count

• Primary benchmarks: 🎉 relevant improvements found
• Secondary benchmarks: no relevant changes found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-0.8%	-0.9%	5
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-0.8%	-0.9%	5

Max RSS (memory usage)

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 😿 relevant regression found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	4.1%	4.1%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

Cycles

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.5%	2.5%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-1.7%	-1.7%	1
All 😿🎉 (primary)	N/A	N/A	0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³

[aliemjay]

I have rebased to adjust for NLL diagnostic regressions. The first commit has not changed.

r? @oli-obk

[oli-obk]

@bors r+

[bors]

📌 Commit 570cf75 has been approved by oli-obk

It is now in the queue for this repository.

[bors]

⌛ Testing commit 570cf75 with merge f097ed2c9de38bd491399e96de8e1f1d1321d2f9...

[bors]

💔 Test failed - checks-actions

[rust-log-analyzer]

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

.......... (60/66)
.....     (66/66)


/checkout/src/test/rustdoc-gui/search-result-display.goml search-result-display... FAILED
[ERROR] (line 5) Error: The following CSS selector "#search-settings" was not found: for command `wait-for: "#search-settings"`
Build completed unsuccessfully in 0:00:46

[jackh726]

Spurious?

@bors retry

[bors]

⌛ Testing commit 570cf75 with merge b90a0ed...

[bors]

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing b90a0ed to master...

[rust-timer]

Finished benchmarking commit (b90a0ed): comparison url.

Instruction count

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 🎉 relevant improvement found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-0.5%	-0.5%	1
All 😿🎉 (primary)	N/A	N/A	0

Max RSS (memory usage)

Results

• Primary benchmarks: 😿 relevant regressions found
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions 😿 (primary)	3.5%	4.4%	2
Regressions 😿 (secondary)	3.1%	3.8%	3
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-2.1%	-2.1%	1
All 😿🎉 (primary)	3.5%	4.4%	2

Cycles

Results

• Primary benchmarks: mixed results
• Secondary benchmarks: no relevant changes found

	mean1	max	count2
Regressions 😿 (primary)	1.3%	1.3%	1
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-2.5%	-2.5%	1
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-0.6%	-2.5%	2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³