Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiletest: never truncate stderr if we'll use it as json #96976

Closed
wants to merge 1 commit into from

Conversation

durin42
Copy link
Contributor

@durin42 durin42 commented May 12, 2022

I started observing some strange failures in larger ui tests that were
caused by environmental conditions (probably paths?) pushing the stderr
size over the truncation limit, causing the tests to fail because the ui
output wasn't valid json due to the truncation marker. Since that seems
like a circumstance we never want, just never truncate output that we'll
interpret as json output.

I started observing some strange failures in larger ui tests that were
caused by environmental conditions (probably paths?) pushing the stderr
size over the truncation limit, causing the tests to fail because the ui
output wasn't valid json due to the truncation marker. Since that seems
like a circumstance we never want, just never truncate output that we'll
interpret as json output.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 12, 2022
@Mark-Simulacrum
Copy link
Member

#96551 is probably the approach we're going to pursue here - the truncation is not itself useful, but rather a mechanism to avoid e.g. oom or other hangs in CI. It also helps keep the amount of output down.

@Mark-Simulacrum
Copy link
Member

Going to close in favor of that PR, but feel free to comment there if you disagree or have thoughts.

@durin42
Copy link
Contributor Author

durin42 commented May 15, 2022

That PR looks like a better overall path. I look forward to it landing! Thanks!

@durin42 durin42 deleted the compiletest-ui-notrunc branch October 20, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants