Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Optimize IdMap #96260

Merged
merged 1 commit into from
Apr 21, 2022
Merged

rustdoc: Optimize IdMap #96260

merged 1 commit into from
Apr 21, 2022

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Apr 20, 2022

Slightly optimizes IdMap, which is hot in markdown_links (context here). There are more improvements that can be made near this place, but this seemed like an easy win locally (although I tried it on top of #94857, so let's see what happens without that PR).

r? @petrochenkov

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Apr 20, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 20, 2022
@Kobzol
Copy link
Contributor Author

Kobzol commented Apr 20, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 20, 2022
@bors
Copy link
Contributor

bors commented Apr 20, 2022

⌛ Trying commit 34e2d3b with merge 9342e57819dbf87e987f6c94aef9dd170cd69646...

@bors
Copy link
Contributor

bors commented Apr 20, 2022

☀️ Try build successful - checks-actions
Build commit: 9342e57819dbf87e987f6c94aef9dd170cd69646 (9342e57819dbf87e987f6c94aef9dd170cd69646)

@rust-timer
Copy link
Collaborator

Queued 9342e57819dbf87e987f6c94aef9dd170cd69646 with parent 51ea9bb, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9342e57819dbf87e987f6c94aef9dd170cd69646): comparison url.

Summary:

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 0 0 11 15 11
mean2 N/A N/A -0.7% -0.6% -0.7%
max N/A N/A -3.1% -2.3% -3.1%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. number of relevant changes ↩

  2. the arithmetic mean of the percent change ↩

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 21, 2022
@Kobzol
Copy link
Contributor Author

Kobzol commented Apr 21, 2022

For comparison, when this was applied after the PR which stops resolver cloning, it improved helloworld doc by almost 5 %.

@petrochenkov
Copy link
Contributor

Nice.
@bors r+

@bors
Copy link
Contributor

bors commented Apr 21, 2022

📌 Commit 34e2d3b has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2022
@petrochenkov petrochenkov mentioned this pull request Apr 21, 2022
Merged
@bors
Copy link
Contributor

bors commented Apr 21, 2022

⌛ Testing commit 34e2d3b with merge 5915368c701f5cf205894c7d1b0e7aa0a480d60a...

@bors
Copy link
Contributor

bors commented Apr 21, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 21, 2022
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@Kobzol
Copy link
Contributor Author

Kobzol commented Apr 21, 2022

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2022
@bors
Copy link
Contributor

bors commented Apr 21, 2022

⌛ Testing commit 34e2d3b with merge de1bc00...

@bors
Copy link
Contributor

bors commented Apr 21, 2022

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing de1bc00 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 21, 2022
@bors bors merged commit de1bc00 into rust-lang:master Apr 21, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 21, 2022
@Kobzol Kobzol deleted the rustdoc-idmap branch April 21, 2022 21:21
@bors bors mentioned this pull request Apr 21, 2022
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (de1bc00): comparison url.

Summary:

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 1 0 11 15 12
mean2 1.0% N/A -0.7% -0.6% -0.6%
max 1.0% N/A -3.1% -2.3% -3.1%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes ↩

  2. the arithmetic mean of the percent change ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Kobzol @rust-timer @bors @petrochenkov @rust-log-analyzer @rust-highfive @rustbot