Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify docs for from_raw_parts on Vec and String #96222

Merged
merged 1 commit into from
May 2, 2022
Merged

Clarify docs for from_raw_parts on Vec and String #96222

merged 1 commit into from
May 2, 2022

Conversation

jmaargh
Copy link
Contributor

@jmaargh jmaargh commented Apr 19, 2022

Closes #95427

Original safety explanation for from_raw_parts was unclear on safety for consuming a C string. This clarifies when doing so is safe.

@jmaargh
Clarify docs for from_raw_parts
4dda047 
Original safety explanation for from_raw_parts was
unclear on safety for consuming a C string. This
clarifies when doing so is safe.
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 19, 2022
@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 19, 2022
JohnTitor
JohnTitor approved these changes May 1, 2022
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JohnTitor
Copy link
Member

r? @JohnTitor @bors r+ rollup+

@bors
Copy link
Contributor

bors commented May 1, 2022

📌 Commit 4dda047 has been approved by JohnTitor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2022
@JohnTitor
Copy link
Member

Err, @bors rollup

@JohnTitor JohnTitor mentioned this pull request May 2, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 2, 2022
@bors
Auto merge of rust-lang#96622 - JohnTitor:rollup-8hckgaj, r=JohnTitor
f6cbc92 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#94126 (Classify BinaryHeap & LinkedList unit tests as such)
 - rust-lang#96222 (Clarify docs for `from_raw_parts` on `Vec` and `String`)
 - rust-lang#96499 (Make it possible to write doctests for bootstrap)
 - rust-lang#96567 (Fix docs for u32 and i32 logs func)
 - rust-lang#96568 (std::fmt: Various fixes and improvements to documentation)
 - rust-lang#96571 (Add a bathroom stall to weird expressions test)
 - rust-lang#96610 (Update browser-ui-test version to 0.9.0)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1785f15 into rust-lang:master May 2, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 2, 2022
@jmaargh jmaargh deleted the john-mark/clarify-from-raw-parts-docs branch April 13, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.

Clarify Vec::from_raw_parts safety examples
6 participants
@jmaargh @rust-highfive @JohnTitor @bors @joshtriplett @rustbot