-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mdbook #96088
Update mdbook #96088
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
@bors r+ rollup=iffy |
📌 Commit 5181422 has been approved by |
Update mdbook This just brings in a few small fixes, particularly a rendering fix for chapter names with markdown in them (like the https://doc.rust-lang.org/nightly/rustc/platform-support/kmc-solid.html page). There's also a minor fix for the search index for duplicate headings. Changelog: https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md#mdbook-0418
Update mdbook This just brings in a few small fixes, particularly a rendering fix for chapter names with markdown in them (like the https://doc.rust-lang.org/nightly/rustc/platform-support/kmc-solid.html page). There's also a minor fix for the search index for duplicate headings. Changelog: https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md#mdbook-0418
That was not the cause of the rollup failure. The real failure was #93784:
The embedded-book error was caused by #95372. Books are allowed to fail via the toolstate mechanism https://rust-lang-nursery.github.io/rust-toolstate/ as can be seen here: #96108 (comment) @bors r=Mark-Simulacrum |
📌 Commit 5181422 has been approved by |
Rollup of 7 pull requests Successful merges: - rust-lang#94985 (Parse inner attributes on inline const block) - rust-lang#95006 (Reject `#[thread_local]` attribute on non-static items) - rust-lang#95426 (Include Refs in Valtree Creation) - rust-lang#95908 (Inline `shallow_resolve_ty` into `ShallowResolver`) - rust-lang#96058 (separate flock implementations into separate modules) - rust-lang#96088 (Update mdbook) - rust-lang#96118 (rustdoc: Rename `def_id` into `item_id` when the type is `ItemId` for readability) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
I've fixed the embedded-book failure upstream in rust-embedded/book#317, @ehuss would you like me to PR updating the submodule here or just wait for another general books update like #95423? |
Thanks for the quick fix! I'll go ahead and post an update shortly. |
This just brings in a few small fixes, particularly a rendering fix for chapter names with markdown in them (like the https://doc.rust-lang.org/nightly/rustc/platform-support/kmc-solid.html page). There's also a minor fix for the search index for duplicate headings.
Changelog: https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md#mdbook-0418