Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Use format-args-capture and remove unnecessary nested blocks in rustc_typeck #96065

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Apr 15, 2022

No description provided.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 15, 2022
@rust-highfive
Copy link
Collaborator

r? @compiler-errors

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 15, 2022
@TaKO8Ki TaKO8Ki marked this pull request as draft April 15, 2022 03:33
@TaKO8Ki TaKO8Ki force-pushed the use-`format-args-capture`-and-remove-unnecessary-nested-blocks branch from 0da4bd9 to a004c71 Compare April 15, 2022 06:54
@TaKO8Ki TaKO8Ki force-pushed the use-`format-args-capture`-and-remove-unnecessary-nested-blocks branch from a004c71 to f9188cc Compare April 15, 2022 07:01
@TaKO8Ki TaKO8Ki changed the title Use format-args-capture and remove unnecessary nested blocks in rustc_typeck Refactor: Use format-args-capture and remove unnecessary nested blocks in rustc_typeck Apr 15, 2022
@TaKO8Ki TaKO8Ki marked this pull request as ready for review April 15, 2022 07:17
@compiler-errors
Copy link
Member

@bors r+ rollup=always

hope this doesn't conflict..

@bors
Copy link
Contributor

bors commented Apr 15, 2022

📌 Commit f9188cc has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 15, 2022
Rollup of 11 pull requests

Successful merges:

 - rust-lang#94457 (Stabilize `derive_default_enum`)
 - rust-lang#94461 (Create (unstable) 2024 edition)
 - rust-lang#94849 (Check var scope if it exist)
 - rust-lang#95194 (remove find_use_placement)
 - rust-lang#95749 (only downgrade selection Error -> Ambiguous if type error is in predicate)
 - rust-lang#96026 (couple of clippy::complexity fixes)
 - rust-lang#96027 (remove function parameters only used in recursion)
 - rust-lang#96034 ([test] Add test cases of untested functions for BTreeSet )
 - rust-lang#96040 (Use u32 instead of i32 for futexes.)
 - rust-lang#96062 (docs: Update tests chapter for Termination stabilization)
 - rust-lang#96065 (Refactor: Use `format-args-capture` and remove unnecessary nested blocks in rustc_typeck)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fa281fd into rust-lang:master Apr 15, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 15, 2022
@TaKO8Ki TaKO8Ki deleted the use-`format-args-capture`-and-remove-unnecessary-nested-blocks branch April 16, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants