Rollup of 4 pull requests #95680
Rollup of 4 pull requests #95680
Conversation
…77, r=compiler-errors Suggest derivable trait on E0277 error Closes rust-lang#95099 .
…davidtwco diagnostics: use correct span for const generics Fixes rust-lang#95616
Update panic docs to make it clearer when to use panic vs Result This is based on a question that came up in one of my [error handling office hours](https://twitter.com/yaahc_/status/1506376624509374467?s=20&t=Sp-cEjrx5kpMdNsAGPOo9w) meetings. I had a user who was fairly familiar with error type design, thiserror and anyhow, and rust in general, but who was still confused about when to use panics vs when to use Result and `Error`. This will also be cross referenced in an error handling FAQ that I will be creating in the https://github.com/rust-lang/project-error-handling repo shortly.
…meters, r=davidtwco Refactor: remove unused function parameters
rustbot
added
T-compiler
|
@bors r+ rollup=never p=5 |
|
📌 Commit 6832964 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (d4c7839): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Footnotes |
|
Regression seems maybe real, based on being across multiple profiles for keccak in particular. Cachegrind seems to point at it being in ObligationForest, though, which is not really modified by this PR -- probably inlining decisions changed, or we're seeing effects from diagnostic code being slightly slower and running in a way that doesn't end up actually emitting the diagnostic? Unclear if that can happen. Given the limited impact though and likely difficulty of investigation, I'm going to mark this as triaged since I don't think spending further time is worthwhile. |
Mark-Simulacrum
added
the
perf-regression-triaged
|
Looking at the graphs for keccak over the last week, it's also plausible this is mostly noise:
|
Successful merges:
Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup