Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 6 pull requests #95675

Closed
wants to merge 15 commits into from
Closed

Rollup of 6 pull requests #95675

wants to merge 15 commits into from

Commits on Apr 4, 2022

  1. diagnostics: use correct span for const generics 

    Fixes rust-lang#95616
    @notriddle
    notriddle committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    6ece80f View commit details
    Browse the repository at this point in the history

  2. Rely on #[link] attribute for unwind on Fuchsia. 

    Closes rust-lang#95575.
    @anp
    anp committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    92246c0 View commit details
    Browse the repository at this point in the history

  3. Update panic docs to make it clearer when to use panic vs Result

    @yaahc
    yaahc committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    ccb704c View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. Suggest derivable trait on E0277

    @ohno418
    ohno418 committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    0d2a000 View commit details
    Browse the repository at this point in the history

  2. Suggest only when Rhs for PartialEq and PartialOrd is the same type a… 

    …s self
    @ohno418
    ohno418 committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    0ff2f58 View commit details
    Browse the repository at this point in the history

  3. Suggest only when all fields impl the trait

    @ohno418
    ohno418 committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    de23782 View commit details
    Browse the repository at this point in the history

  4. Fix ui test for nll

    @ohno418
    ohno418 committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    b831b60 View commit details
    Browse the repository at this point in the history

  5. remove unused function parameters

    @TaKO8Ki
    TaKO8Ki committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    9759804 View commit details
    Browse the repository at this point in the history

  6. ⬆️ rust-analyzer

    @lnicola
    lnicola committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    505573e View commit details
    Browse the repository at this point in the history

  7. Rollup merge of rust-lang#95525 - ohno418:suggest-derivable-trait-E02… 

    …77, r=compiler-errors

Suggest derivable trait on E0277 error

Closes rust-lang#95099 .
    @Dylan-DPC
    Dylan-DPC committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    e028d93 View commit details
    Browse the repository at this point in the history

  8. Rollup merge of rust-lang#95654 - notriddle:notriddle/issue-95616, r=… 

    …davidtwco

diagnostics: use correct span for const generics

Fixes rust-lang#95616
    @Dylan-DPC
    Dylan-DPC committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    33b0fba View commit details
    Browse the repository at this point in the history

  9. Rollup merge of rust-lang#95659 - anp:remove-link-print, r=tmandry 

    Rely on #[link] attribute for unwind on Fuchsia.

Closes rust-lang#95575.
    @Dylan-DPC
    Dylan-DPC committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    cd7543f View commit details
    Browse the repository at this point in the history

  10. Rollup merge of rust-lang#95660 - yaahc:panic-docs-update, r=Dylan-DPC 

    Update panic docs to make it clearer when to use panic vs Result

This is based on a question that came up in one of my [error handling office hours](https://twitter.com/yaahc_/status/1506376624509374467?s=20&t=Sp-cEjrx5kpMdNsAGPOo9w) meetings. I had a user who was fairly familiar with error type design, thiserror and anyhow, and rust in general, but who was still confused about when to use panics vs when to use Result and `Error`.

This will also be cross referenced in an error handling FAQ that I will be creating in the https://github.com/rust-lang/project-error-handling repo shortly.
    @Dylan-DPC
    Dylan-DPC committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    0826ef7 View commit details
    Browse the repository at this point in the history

  11. Rollup merge of rust-lang#95670 - TaKO8Ki:remove-unused-function-para… 

    …meters, r=davidtwco

Refactor: remove unused function parameters
    @Dylan-DPC
    Dylan-DPC committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    9711e9d View commit details
    Browse the repository at this point in the history

  12. Rollup merge of rust-lang#95673 - lnicola:rust-analyzer-2022-04-05, r… 

    …=lnicola

⬆️ rust-analyzer

r? `@ghost`
    @Dylan-DPC
    Dylan-DPC committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    73a8f95 View commit details
    Browse the repository at this point in the history