Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix x doc compiler/rustc #95502

Merged
merged 4 commits into from
Apr 10, 2022
Merged

Fix x doc compiler/rustc #95502

merged 4 commits into from
Apr 10, 2022

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Mar 30, 2022

This also has a few cleanups to doc.rs. The last two commits I don't care about, but the first commit I'd like to keep - it will be very useful for #44293.

Fixes #95447.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2022
@jyn514 jyn514 mentioned this pull request Mar 30, 2022
Merged
@jyn514
Simplify make_run for test::Crate by introducing crate_paths in…
400f23e 
…stead of calculating them after the fact
@jyn514
Fix x doc compiler/rustc
50d1ee9 
This works by mapping the local path to a crate name before trying to fetch crates it depends on.
@jyn514
Remove dead code in doc.rs
43c16ac 
`run` is never called for invalid paths; they get filtered out by `should_run`.
@jyn514
Reduce duplication in impl Step for doc::Rustc
7231591 
This should have no user-visible change.
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 10, 2022

📌 Commit 7231591 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2022
@bors
Copy link
Contributor

bors commented Apr 10, 2022

⌛ Testing commit 7231591 with merge 341883d...

@bors
Copy link
Contributor

bors commented Apr 10, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 341883d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 10, 2022
@bors bors merged commit 341883d into rust-lang:master Apr 10, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 10, 2022
@rust-timer
Copy link
Collaborator

This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@jyn514 jyn514 deleted the doc-rustc branch April 10, 2022 15:21
This was referenced Jul 10, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.

x doc compiler/rustc panics
6 participants
@jyn514 @rust-highfive @Mark-Simulacrum @bors @rust-timer @rustbot