Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that '_ and GAT yields errors #95312

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Ensure that '_ and GAT yields errors #95312

merged 1 commit into from
Apr 28, 2022
+42 −0

Conversation

marmeladema
Copy link
Contributor

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 25, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 25, 2022
@jackh726
Copy link
Member

Given that this is behavior we'd like to change sometime in the future, I think a short comment on these tests would be good. (Basically, why we expect an error now and how we might change it in the future.)

I also think these can just be one test.

r=me with those changes

@bors delegate+

@bors
Copy link
Contributor

bors commented Mar 25, 2022

✌️ @marmeladema can now approve this pull request

@apiraino
Copy link
Contributor

I think the cureent status is now waiting on author (that can also approve this PR themself)

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2022
@jackh726
Copy link
Member

ping @marmeladema for this :)

@marmeladema
Copy link
Contributor Author

Given that this is behavior we'd like to change sometime in the future, I think a short comment on these tests would be good. (Basically, why we expect an error now and how we might change it in the future.)

I am not sure what comment to add because I don't really know why its not supported right now nor what we would expect to do in the future :/

@marmeladema marmeladema force-pushed the tests-for-issue-95305 branch from aa380b2 to d9240d7 Compare April 27, 2022 22:36
@jackh726
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 27, 2022

📌 Commit d9240d7 has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 27, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 28, 2022
@Dylan-DPC
Rollup merge of rust-lang#95312 - marmeladema:tests-for-issue-95305, …
a67b394 
…r=jackh726

Ensure that `'_` and GAT yields errors

Fixes rust-lang#95305

`@bors` r? `@jackh726`
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 28, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 28, 2022
@Dylan-DPC
Rollup merge of rust-lang#95312 - marmeladema:tests-for-issue-95305, …
9e97ba2 
…r=jackh726

Ensure that `'_` and GAT yields errors

Fixes rust-lang#95305

``@bors`` r? ``@jackh726``
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 28, 2022
Closed
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 28, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 28, 2022
@bors
Auto merge of rust-lang#96528 - Dylan-DPC:rollup-iedbjli, r=Dylan-DPC
e85edd9 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#95312 (Ensure that `'_` and GAT yields errors)
 - rust-lang#96405 (Migrate ambiguous plus diagnostic to the new derive macro)
 - rust-lang#96409 (Recover suggestions to introduce named lifetime under NLL)
 - rust-lang#96433 (rustc_ast: Harmonize delimiter naming with `proc_macro::Delimiter`)
 - rust-lang#96480 (Fixed grammatical error in example comment)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d665a5e into rust-lang:master Apr 28, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 28, 2022
@marmeladema marmeladema deleted the tests-for-issue-95305 branch April 28, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackh726 jackh726 jackh726 approved these changes

Assignees

@jackh726 jackh726

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.

ensure that '_ and GATs yields errors
6 participants
@marmeladema @jackh726 @bors @apiraino @rust-highfive @rustbot