Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diagnostics: do not spurriously claim something is "not an iterator" #94870

Merged
merged 1 commit into from
Mar 12, 2022
Merged

diagnostics: do not spurriously claim something is "not an iterator" #94870

merged 1 commit into from
Mar 12, 2022

Conversation

notriddle
Copy link
Contributor

Fixes a minor regression caused by #94746, where iter::Filter is spurriously declared "not an iterator."

@notriddle
diagnostics: do not spurriously claim something is "not an iterator"
317f684 
Fixes a minor regression caused by rust-lang#94746, where iter::Filter is
spurriously declared "not an iterator."
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 12, 2022
@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 12, 2022
@oli-obk oli-obk added the A-diagnostics Area: Messages for errors, warnings, and lints label Mar 12, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Mar 12, 2022

r? @oli-obk

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 12, 2022

📌 Commit 317f684 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2022
@bors
Copy link
Contributor

bors commented Mar 12, 2022

⌛ Testing commit 317f684 with merge 2582566...

@bors
Copy link
Contributor

bors commented Mar 12, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 2582566 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 12, 2022
@bors bors merged commit 2582566 into rust-lang:master Mar 12, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 12, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2582566): comparison url.

Summary: This benchmark run did not return any relevant results. 15 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@notriddle notriddle deleted the notriddle/filter-regression branch March 12, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
A-diagnostics Area: Messages for errors, warnings, and lints merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
7 participants
@notriddle @rust-highfive @oli-obk @bors @rust-timer @matthewjasper @rustbot