Rollup of 16 pull requests

[Dylan-DPC]

Successful merges:

• Make some Clone impls const #91804 (Make some Clone impls const)
• Mention intent of From trait in its docs #92541 (Mention intent of From trait in its docs)
• Add Iterator::collect_into #93057 (Add Iterator::collect_into)
• Treat constant values as mir::ConstantKind::Val #94059 (Treat constant values as mir::ConstantKind::Val)
• [1/2] Implement macro meta-variable expressions #94368 ([1/2] Implement macro meta-variable expressions)
• Use MaybeUninit in VecDeque to remove the undefined behavior of slice #94472 (Use MaybeUninit in VecDeque to remove the undefined behavior of slice)
• Fix soundness issue in scoped threads. #94644 (Fix soundness issue in scoped threads.)
• Constify Index{,Mut} for [T], str, and [T; N] #94657 (Constify Index{,Mut} for [T], str, and [T; N])
• Statically compile libstdc++ everywhere if asked #94719 (Statically compile libstdc++ everywhere if asked)
• Suggest if let/let_else for refutable pat in let #94739 (Suggest if let/let_else for refutable pat in let)
• Unify impl blocks by wrapping them into a div #94740 (Unify impl blocks by wrapping them into a div)
• Improve rustdoc book #94753 (Improve rustdoc book)
• Warn users about || in let chain expressions #94754 (Warn users about || in let chain expressions)
• Add documentation about lifetimes to thread::scope. #94763 (Add documentation about lifetimes to thread::scope.)
• Ignore close_read_wakes_up test on SGX platform #94768 (Ignore close_read_wakes_up test on SGX platform)
• Add miri to the well known conditional compilation names and values #94772 (Add miri to the well known conditional compilation names and values)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[Dylan-DPC]

@bors r+ rollup=never p=5

[bors]

📌 Commit 3257f81 has been approved by Dylan-DPC

[matthiaskrgr]

@Dylan-DPC I would suggest to not make such big rollups, if this introduces a perf regression it might be pain to debug where it's comming from.

[matthiaskrgr]

CI already failed, closing

test [ui] run-pass/vec.rs ... ok
diff of stdout:

-[2, 2] Iter([2, 2], [])
+[2, 2] Iter([core::mem::maybe_uninit::MaybeUninit<alloc::boxed::Box<i32>>, core::mem::maybe_uninit::MaybeUninit<alloc::boxed::Box<i32>>], [])
 Iter([], [])
 

The actual stdout differed from the expected stdout.
Actual stdout saved to /tmp/compiletest20lDZR/vecdeque.stage-id.stdout
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args vecdeque.rs`

error: 1 errors occurred comparing output.
status: exit status: 0
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin/miri" "tests/run-pass/vecdeque.rs" "-L" "/tmp/compiletest20lDZR" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-C" "prefer-dynamic" "-o" "/tmp/compiletest20lDZR/vecdeque.stage-id" "-A" "unused" "--edition" "2018" "-Astable-features" "--sysroot" "/home/user/.cache/miri/HOST" "-Zmiri-tag-raw-pointers" "-L" "/tmp/compiletest20lDZR/vecdeque.stage-id.aux"
stdout:
------------------------------------------
[2, 2] Iter([core::mem::maybe_uninit::MaybeUninit<alloc::boxed::Box<i32>>, core::mem::maybe_uninit::MaybeUninit<alloc::boxed::Box<i32>>], [])
Iter([], [])

------------------------------------------
stderr:
------------------------------------------

------------------------------------------

test [ui] run-pass/vecdeque.rs ... FAILED
test [ui] run-pass/float.rs ... ok

[Dylan-DPC]

CI was failing because previous rustdoc issue that hasn't been merged yet

[matthiaskrgr]

Yes the rustdoc failure was also happening, after the miri test failure
https://github.com/rust-lang/rust/runs/5487191514?check_suite_focus=true#step:26:7625

[rust-log-analyzer]

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  IMAGE: x86_64-gnu-tools
##[endgroup]
From https://github.com/rust-lang/rust
 * branch              master     -> FETCH_HEAD
Searching for toolstate changes between 10dccdc7fcbdc64ee9efe2c1ed975ab8c1d61287 and 948611f1a7e712b9d01dd8a13bfd609bb1d5681e
Rustdoc was updated
##[group]Run src/ci/scripts/verify-channel.sh
src/ci/scripts/verify-channel.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
---
test [ui] run-pass/vec.rs ... ok
diff of stdout:

-[2, 2] Iter([2, 2], [])
+[2, 2] Iter([core::mem::maybe_uninit::MaybeUninit<alloc::boxed::Box<i32>>, core::mem::maybe_uninit::MaybeUninit<alloc::boxed::Box<i32>>], [])
 

The actual stdout differed from the expected stdout.
Actual stdout saved to /tmp/compiletest20lDZR/vecdeque.stage-id.stdout
Actual stdout saved to /tmp/compiletest20lDZR/vecdeque.stage-id.stdout
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args vecdeque.rs`

error: 1 errors occurred comparing output.
status: exit status: 0
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin/miri" "tests/run-pass/vecdeque.rs" "-L" "/tmp/compiletest20lDZR" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-C" "prefer-dynamic" "-o" "/tmp/compiletest20lDZR/vecdeque.stage-id" "-A" "unused" "--edition" "2018" "-Astable-features" "--sysroot" "/home/user/.cache/miri/HOST" "-Zmiri-tag-raw-pointers" "-L" "/tmp/compiletest20lDZR/vecdeque.stage-id.aux"
------------------------------------------
------------------------------------------
[2, 2] Iter([core::mem::maybe_uninit::MaybeUninit<alloc::boxed::Box<i32>>, core::mem::maybe_uninit::MaybeUninit<alloc::boxed::Box<i32>>], [])

------------------------------------------
stderr:
------------------------------------------
---
.......... (60/61)
.          (61/61)


/checkout/src/test/rustdoc-gui/mobile.goml mobile... FAILED
[ERROR] (line 27) Error: Evaluation failed: assert didn't fail: for command `compare-elements-position-near-false: ("#preferred-light-theme .setting-name", "#preferred-light-theme .choice", {"y": 16})`
Build completed unsuccessfully in 0:00:17