remove_dir_all: use fallback implementation on Miri #94749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Can you add a user-facing note about this in the |
|
Sure... not what I expected (I don't think we have other such notes for Miri), but why not. |
RalfJung
commented
Mar 9, 2022
| @@ -1480,14 +1480,14 @@ pub fn chroot(dir: &Path) -> io::Result<()> { | |||
|
|
|||
| pub use remove_dir_impl::remove_dir_all; | |||
|
|
|||
| // Fallback for REDOX and ESP-IDF | |||
| #[cfg(any(target_os = "redox", target_os = "espidf"))] | |||
| // Fallback for REDOX and ESP-IDF (and Miri) | |||
There was a problem hiding this comment.
FWIW the docs also do not seem to mention ESP-IDF (whatever that is)
|
@cuviper since you left a comment earlier -- can I assign this PR to you, or should I try to find another reviewer? |
|
📌 Commit 28eb06b has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 19, 2022
…iper remove_dir_all: use fallback implementation on Miri Fixes rust-lang/miri#1966 The new implementation requires `openat`, `unlinkat`, and `fdopendir`. These cannot easily be shimmed in Miri since libstd does not expose APIs corresponding to them. So for now it is probably easiest to just use the fallback code in Miri. Nobody should run Miri as root anyway...
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 20, 2022
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#94749 (remove_dir_all: use fallback implementation on Miri) - rust-lang#94948 (Fix diagnostics for `#![feature(deprecated_suggestion)]`) - rust-lang#94989 (Add Stream alias for AsyncIterator) - rust-lang#95108 (Give more details in `Display` for `hir::Target`) - rust-lang#95110 (Provide more useful documentation of conversion methods) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Mar 20, 2022
test remove_dir_all Blocked on rust-lang/rust#94749 Cc #1966
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rust-lang/miri#1966
The new implementation requires
openat,unlinkat, andfdopendir. These cannot easily be shimmed in Miri since libstd does not expose APIs corresponding to them. So for now it is probably easiest to just use the fallback code in Miri. Nobody should run Miri as root anyway...