Improve AdtDef interning.

[nnethercote]

This commit makes AdtDef use Interned. Much of the commit is tedious
changes to introduce getter functions. The interesting changes are in
compiler/rustc_middle/src/ty/adt.rs.

r? @fee1-dead

[rust-highfive]

Some changes occured to rustc_codegen_gcc

cc @antoyo

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

Some changes occured to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occured to rustc_codegen_cranelift

cc @bjorn3

[fee1-dead]

Since AdtDef already uses its DefId as a hash I don't think there is going to be any performance impact here, but it is nice to be safe.

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 535c26fa26876bf6305d840b65b83a780b8d9128 with merge 97e4e12bccb6d65473261eb5813514d27e23a42f...

[bors]

☀️ Try build successful - checks-actions
Build commit: 97e4e12bccb6d65473261eb5813514d27e23a42f (97e4e12bccb6d65473261eb5813514d27e23a42f)

[rust-timer]

Queued 97e4e12bccb6d65473261eb5813514d27e23a42f with parent d2710db, future comparison URL.

[camsteffen]

These interning changes are neat.

[rust-timer]

Finished benchmarking commit (97e4e12bccb6d65473261eb5813514d27e23a42f): comparison url.

Summary: This benchmark run shows 17 relevant improvements 🎉 to instruction counts.

• Arithmetic mean of relevant improvements: -0.5%
• Largest improvement in instruction counts: -0.7% on full builds of wg-grammar check

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

[nnethercote]

I have fixed the conflicts. I also introduced AdtDef::variant() and rewrote a bunch of def.variants()[n] expressions as def.variant(n).

[fee1-dead]

LGTM, Thanks!

[fee1-dead]

@bors r+

[bors]

📌 Commit ca5525d has been approved by fee1-dead

[bors]

⌛ Testing commit ca5525d with merge b0b618a6a8003ad7d8f573e7f20bfa790fc079b6...

[bors]

💔 Test failed - checks-actions

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[fee1-dead]

@bors retry apple builder vanished

[bors]

⌛ Testing commit ca5525d with merge 012720f...

[bors]

☀️ Test successful - checks-actions
Approved by: fee1-dead
Pushing 012720f to master...

[rust-highfive]

📣 Toolstate changed by #94733!

Tested on commit 012720f.
Direct link to PR: #94733

💔 miri on windows: test-fail → build-fail (cc @eddyb @RalfJung @oli-obk).
💔 miri on linux: test-fail → build-fail (cc @eddyb @RalfJung @oli-obk).

[rust-timer]

Finished benchmarking commit (012720f): comparison url.

Summary: This benchmark run shows 30 relevant improvements 🎉 to instruction counts.

• Arithmetic mean of relevant improvements: -0.5%
• Largest improvement in instruction counts: -1.2% on full builds of match-stress-enum doc

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression