riscv32imc_esp_espidf: set max_atomic_width to 64 #94292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 65614e9 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 24, 2022
…askrgr Rollup of 9 pull requests Successful merges: - rust-lang#89887 (Change `char` type in debuginfo to DW_ATE_UTF) - rust-lang#94267 (Remove unused ordering derivations and bounds for `SimplifiedTypeGen`) - rust-lang#94270 (Miri: relax fn ptr check) - rust-lang#94273 (add matching doc to errorkind) - rust-lang#94283 (remove feature gate in control_flow examples) - rust-lang#94288 (Cleanup a few Decoder methods) - rust-lang#94292 (riscv32imc_esp_espidf: set max_atomic_width to 64) - rust-lang#94296 (:arrow_up: rust-analyzer) - rust-lang#94300 (Fix a typo in documentation of `array::IntoIter::new_unchecked`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For espidf targets without native atomics, there is atomic emulation inside the newlib component of espidf, this has been extended to support emulation up to 64bits therefore we are safe to increase the atomic width for the
riscv32imc_esp_espidftarget.Closes esp-rs#107
cc: @ivmarkov