Treat unstable lints as unknown #94274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @lcnr |
lcnr
reviewed
Feb 24, 2022
|
lgtm, but not too familiar with this code, so r? @tmandry generally don't have strong opinions about how exactly this should behave |
djkoloski
force-pushed
the
unknown_unstable_lints
branch
from
37518af to
06b9f06
Compare
This comment has been minimized.
This comment has been minimized.
djkoloski
force-pushed
the
unknown_unstable_lints
branch
from
06b9f06 to
a618097
Compare
This comment has been minimized.
This comment has been minimized.
djkoloski
force-pushed
the
unknown_unstable_lints
branch
2 times, most recently
from
b90ef17 to
d55d9d5
Compare
tmandry
requested changes
Mar 1, 2022
src/test/ui/feature-gates/feature-gate-non_exhaustive_omitted_patterns_lint.stderr
Outdated
Show resolved
Hide resolved
src/test/ui/feature-gates/feature-gate-test_unstable_lint.stderr
Outdated
Show resolved
Hide resolved
|
☔ The latest upstream changes (presumably #87835) made this pull request unmergeable. Please resolve the merge conflicts. |
djkoloski
force-pushed
the
unknown_unstable_lints
branch
from
f71ad77 to
9847405
Compare
|
☔ The latest upstream changes (presumably #90076) made this pull request unmergeable. Please resolve the merge conflicts. |
added 4 commits
March 8, 2022 19:06
This change causes unstable lints to be ignored if the `unknown_lints` lint is allowed. To achieve this, it also changes lints to apply as soon as they are processed. Previously, lints in the same set were processed as a batch and then all simultaneously applied. Implementation of rust-lang/compiler-team#469
This also affects the `non_exhaustive_omitted_patterns` and `must_not_suspend` lints as they are not stable. This also changes the diagnostic level to pull from `unknown_lints` instead of always being allow or deny.
djkoloski
force-pushed
the
unknown_unstable_lints
branch
from
9847405 to
fa10d90
Compare
This comment has been minimized.
This comment has been minimized.
|
@bors r+ rollup |
|
📌 Commit 1c31a95 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 10, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#93950 (Use modern formatting for format! macros) - rust-lang#94274 (Treat unstable lints as unknown) - rust-lang#94368 ([1/2] Implement macro meta-variable expressions) - rust-lang#94719 (Statically compile libstdc++ everywhere if asked) - rust-lang#94728 (Only emit pointer-like metadata for `Box<T, A>` when `A` is ZST) - rust-lang#94790 (enable portable-simd doctests in Miri) - rust-lang#94811 (Update browser-ui-test version) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change causes unstable lints to be ignored if the
unknown_lintslint is allowed. To achieve this, it also changes lints to apply as soon
as they are processed. Previously, lints in the same set were processed
as a batch and then all simultaneously applied.
Implementation of rust-lang/compiler-team#469