Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Remove unnecessary -Zunstable-flags in docs #94076

Closed
wants to merge 1 commit into from
Closed

Docs: Remove unnecessary -Zunstable-flags in docs #94076

wants to merge 1 commit into from

Conversation

jschwe
Copy link
Contributor

@jschwe jschwe commented Feb 17, 2022

PR #90132 stabilized instrument-coverage, but missed removing an occurance of -Zunstable-flags when changing -Z to -C.

@jschwe
Remove unnecessary -Zunstable-flags in docs
08d9371 
PR #90132 stabilized instrument-coverage, but missed removing an occurance of -Zunstable-flags when changing -Z to -C.
@rust-highfive
Copy link
Collaborator

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 17, 2022
@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Feb 17, 2022

📌 Commit 08d9371 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2022
@EFanZh
Copy link
Contributor

EFanZh commented Feb 17, 2022 •
edited
Loading

Isn’t this -Z unstable-options for -C symbol-mangling-version=legacy? Since only value v0 is stabilized: #90128.

@GuillaumeGomez
Copy link
Member

You might be right.

@bors: r-

Just in case, I'll put someone from the compiler team to confirm it.

r? @pnkfelix

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 17, 2022
@jschwe
Copy link
Contributor Author

jschwe commented Feb 17, 2022

Isn’t this -Z unstable-options for -C symbol-mangling-version=legacy

Ah, I see. I previously thought that -C options are stable. But I guess it makes sense that there may be values of an option that are unstable.

Sorry for the noise

@jschwe jschwe closed this Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@pnkfelix pnkfelix

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jschwe @rust-highfive @GuillaumeGomez @bors @EFanZh @pnkfelix