Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update browser-ui-test version #93597

Merged
merged 2 commits into from
Feb 5, 2022
Merged

Update browser-ui-test version #93597

merged 2 commits into from
Feb 5, 2022

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Feb 2, 2022 •
edited
Loading

The puppeteer version update is limited because new versions has some "interesting" flaws.

r? @jsha

@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Feb 2, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 2, 2022
@jsha
Copy link
Contributor

jsha commented Feb 3, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 3, 2022

📌 Commit 1dbdfc4 has been approved by jsha

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 3, 2022
@matthiaskrgr
Rollup merge of rust-lang#93597 - GuillaumeGomez:update-browser-ui-te…
b0037f4 
…st, r=jsha

Update browser-ui-test version

The puppeteer version update is limited because new versions has some "interesting" flaws.

r? `@jsha`
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 3, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 3, 2022
@matthiaskrgr
Rollup merge of rust-lang#93597 - GuillaumeGomez:update-browser-ui-te…
511dca5 
…st, r=jsha

Update browser-ui-test version

The puppeteer version update is limited because new versions has some "interesting" flaws.

r? ``@jsha``
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 3, 2022
Closed
@matthiaskrgr
Copy link
Member

Hmmh, I think this might be responsible for this rollup failure / rustdoc test failure:
#93625 (comment)
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 3, 2022
@GuillaumeGomez
Copy link
Member Author

@matthiaskrgr I doesn't seem related. We can keep it out of rollups if you prefer though.

@bors: r=jsha

@bors
Copy link
Contributor

bors commented Feb 3, 2022

📌 Commit 1dbdfc4 has been approved by jsha

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 3, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 3, 2022
@matthiaskrgr
Rollup merge of rust-lang#93597 - GuillaumeGomez:update-browser-ui-te…
6cf7b3a 
…st, r=jsha

Update browser-ui-test version

The puppeteer version update is limited because new versions has some "interesting" flaws.

r? `@jsha`
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 3, 2022
Closed
@matthiaskrgr
Copy link
Member

@bors rollup=never another rollup attempt failed, let's see

@ehuss
Copy link
Contributor

ehuss commented Feb 4, 2022

@bors r-

This PR is definitely the cause of the errors, it fails when rebased:


/checkout/src/test/rustdoc-gui/sidebar-mobile.goml sidebar-mobile... FAILED
[ERROR] (line 42) Error: Evaluation failed: different Y values: 543 != 542.96875: for command `assert-position: (".block.keyword li:nth-child(1)", {"y"
: 542.96875})`

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 4, 2022
@GuillaumeGomez
Copy link
Member Author

I updated a comment in a GUI test to ensure ahead of time that the test isn't failing before r+ing again.

@GuillaumeGomez
Copy link
Member Author

Seems like GUI tests passed so let's go!

@bors: r+

@bors
Copy link
Contributor

bors commented Feb 5, 2022

📌 Commit ef00e3b has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 5, 2022
@GuillaumeGomez
Copy link
Member Author

Arf forgot...

@bors: r=jsha

@bors
Copy link
Contributor

bors commented Feb 5, 2022

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Feb 5, 2022

📌 Commit ef00e3b has been approved by jsha

@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 5, 2022
Merged
@bors
Copy link
Contributor

bors commented Feb 5, 2022

⌛ Testing commit ef00e3b with merge 291bf94...

@bors
Copy link
Contributor

bors commented Feb 5, 2022

☀️ Test successful - checks-actions
Approved by: jsha
Pushing 291bf94 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 5, 2022
@bors bors merged commit 291bf94 into rust-lang:master Feb 5, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 5, 2022
@bors bors mentioned this pull request Feb 5, 2022
Merged
@GuillaumeGomez GuillaumeGomez deleted the update-browser-ui-test branch February 5, 2022 19:21
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (291bf94): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@ehuss ehuss mentioned this pull request Feb 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jsha jsha

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.
8 participants
@GuillaumeGomez @jsha @bors @matthiaskrgr @ehuss @rust-timer @rust-highfive @rustbot