Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add HashStableEq trait, and use it in query code #93467

Closed
wants to merge 18 commits into from

Conversation

Aaron1011
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

Some changes occured to the CTFE / Miri engine

cc @rust-lang/miri

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 29, 2022
@rust-highfive
Copy link
Collaborator

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 29, 2022
@Aaron1011
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 29, 2022
@bors
Copy link
Contributor

bors commented Jan 29, 2022

⌛ Trying commit e4752aba0e7e2eea6ab5d58b56d7cc153e824e9f with merge 1e58cf04417b05a1ecb0aca7e5f594918a5877b1...

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Jan 29, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2022
@Aaron1011
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Jan 29, 2022

⌛ Trying commit 0f179293f49c33f4f1f2efa9b7ddf8e8145e8988 with merge c10a3c94795ff23b162b5aa7bcd14569f59d7c28...

@rust-log-analyzer

This comment has been minimized.

@Aaron1011
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Jan 30, 2022

⌛ Trying commit 0f179293f49c33f4f1f2efa9b7ddf8e8145e8988 with merge 708eedd810b7db0b1413d2f2f814686e767220cf...

@bors
Copy link
Contributor

bors commented Jan 30, 2022

☀️ Try build successful - checks-actions
Build commit: 708eedd810b7db0b1413d2f2f814686e767220cf (708eedd810b7db0b1413d2f2f814686e767220cf)

@rust-timer
Copy link
Collaborator

Queued 708eedd810b7db0b1413d2f2f814686e767220cf with parent a00e130, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (708eedd810b7db0b1413d2f2f814686e767220cf): comparison url.

Summary: This benchmark run shows 365 relevant regressions 😿 to instruction counts.

  • Average relevant regression: 1.3%
  • Largest regression in instruction counts: 5.2% on full builds of externs debug

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jan 30, 2022
@Kobzol

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Feb 9, 2022

☀️ Try build successful - checks-actions
Build commit: 8c74413655e1246710ed56d1169a1873e8eff36f (8c74413655e1246710ed56d1169a1873e8eff36f)

@rust-timer
Copy link
Collaborator

Queued 8c74413655e1246710ed56d1169a1873e8eff36f with parent cc38176, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8c74413655e1246710ed56d1169a1873e8eff36f): comparison url.

Summary: This benchmark run shows 13 relevant improvements 🎉 but 81 relevant regressions 😿 to instruction counts.

  • Average relevant regression: 0.8%
  • Average relevant improvement: -1.1%
  • Largest improvement in instruction counts: -1.7% on full builds of match-stress-enum check
  • Largest regression in instruction counts: 2.8% on full builds of ctfe-stress-4 check

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 9, 2022
@bors
Copy link
Contributor

bors commented Feb 24, 2022

☔ The latest upstream changes (presumably #94314) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnCSimon JohnCSimon removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 20, 2022
@camelid camelid added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 2, 2022
@JohnCSimon
Copy link
Member

@Aaron1011
Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.
Note: if you do please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.
Thanks for your contribution.

@rustbot label: +S-inactive

@JohnCSimon JohnCSimon closed this Jan 29, 2023
@rustbot rustbot added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants