Liberate late bound regions when collecting GAT substs in wfcheck #93227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
@compiler-errors I believe you commited a binary |
|
hahaha yep! let me fix that. @rustbot author |
rustbot
added
S-waiting-on-author
|
Is |
|
@jackh726 No the |
compiler-errors
force-pushed
the
gat-hrtb-wfcheck
branch
from
f7f1d98
to
4a74ace
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
Great. @bors r+ rollup |
|
📌 Commit 4a74ace has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 23, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#91526 (rustc_lint: Some early linting refactorings) - rust-lang#92555 (Implement RFC 3151: Scoped threads.) - rust-lang#93213 (Fix `let_chains` and `if_let_guard` feature flags) - rust-lang#93219 (Add preliminary support for inline assembly for msp430.) - rust-lang#93226 (Normalize field access types during borrowck) - rust-lang#93227 (Liberate late bound regions when collecting GAT substs in wfcheck) - rust-lang#93229 (Remove DiagnosticBuilder.quiet) - rust-lang#93234 (rustc_mir_itertools: Avoid needless `collect` with itertools) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
eggyal
added a commit
to eggyal/rust
that referenced
this pull request
Jun 18, 2022
rust-lang#93227 liberated late bound regions when collecting GAT substs in wfcheck. It should simply skip late bound regions instead. r? @compiler-errors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 19, 2022
…lding, r=jackh726 Skip late bound regions in GATSubstCollector rust-lang#93227 liberated late bound regions when collecting GAT substs in wfcheck. It should simply skip late bound regions instead. r? `@compiler-errors`
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 19, 2022
…lding, r=jackh726 Skip late bound regions in GATSubstCollector rust-lang#93227 liberated late bound regions when collecting GAT substs in wfcheck. It should simply skip late bound regions instead. r? ``@compiler-errors``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue here is that the
GATSubstCollectordoes not currently do anything wrtBinders, so the GAT substs it copies out have escaping late bound regions when it walks through types likefor<'x> fn() -> Self::Gat<'x>.I made that visitor call
liberate_late_bound_regions, not sure if that's the right thing here or we need to do something else to replace these bound vars with placeholders. I'm not familiar with other code doing anything similar.. But the issue is indeed no longer ICEing.Fixes #92954
r? @jackh726
since you last touched this code, feel free to reassign